Separate client and daemon #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGFae
force-pushed
the
separate-client-and-daemon
branch
from
aff6a04 to
154fda7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This separates
swwwinto two programs: a client and a "server". The "server" is just our previous daemon.I moved everything I could to the client, so as to lessen the daemon's dependencies and code size. On my machine, this seems to have as much as halved the overall memory usage, both when animating a large gif, and when doing many image transitions. I personally also believe that the code looks simpler now. The daemon's internal logic was greatly simplified. The most complicated thing now is how the client needs to ask the daemon the outputs' size to know how to resize the image.
Currently, this version should work 100% correctly, but I still plan to test it more before merging.
Furthermore, I was thinking of making more modifications to the code, to make it more organized in general.
Closes #52