prioritize fractional scale events

[LGFae]

We currently let preferred_buffer_scale events overwrite the values we received from the fractional scale protocol. This is incorrect. Wayland is an entirely assynchronous protocol, so we should prioritize the more precise events over the more generic ones.

[LOSEARDES77]

I have been bisecting this and found this as the first bad commit 56928f7

[LGFae]

bad commit... for which issue? Note someone has already pointed at that commit in issue #386, which should also be fixed by this PR.

[LOSEARDES77]

Ho sorry i got confused i thought this was for the incorrect scaling issue

[LOSEARDES77]

This pr solved the fractional scaling issue. I just tested

[LOSEARDES77]

I am still getting an error but that was happening before too and everything works as intended

         0ms [INFO]  selected pixel format: Xbgr
       110ms [INFO]  BumpPool with: 1 buffers. Size: 16000Kb
       152ms [ERROR] We failed to find wayland buffer with id: 11. This should be impossible.
       152ms [ERROR] We failed to find wayland buffer with id: 11. This should be impossible.
       270ms [INFO]  BumpPool with: 1 buffers. Size: 16000Kb
       310ms [ERROR] We failed to find wayland buffer with id: 8. This should be impossible.

[LGFae]

Yeah, that's unrelated.

[Lstpr4]

Can you give me help on how to fix the issue?

[LGFae]

As this was already released, you would need to wait until your distro releases the latest swww version (0.10.2), or simply clone this repository and try installing it manually yourself. I cannot comment on how do that as it is specific to every distro.

[everyoneexe]

Fix Applied
File: client/src/imgproc.rs
Line: 452

Removed .fit_into_destination(Some((0.5, 0.5))) — took a different route than you folks, only to realize you patched it more elegantly later on 😅
Anyway, bug's gone. Different scalpel, same surgery.