Skip to content

fix Transaction.getChainId when v=27 must return null #2133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

jpnovais
Copy link
Contributor

What does this PR do?

fix deriveChainId(long v), when v=27 or v=28 must return null instead of 0, as per EIP155

Where should the reviewer start?

crypto/src/main/java/org/web3j/crypto/TransactionUtils.java#deriveChainId

Why is it needed?

The current seems to be buggy and comply with the EIP155 spec

Checklist

  • I've read the contribution guidelines.
  • I've added tests (if applicable).
  • I've added a changelog entry if necessary.

@jpnovais jpnovais force-pushed the fix-transaction-deriveChainId branch from 8774b65 to 22dd273 Compare December 20, 2024 19:13
Copy link
Member

@NickSneo NickSneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for pointing out

@NickSneo NickSneo merged commit 567e21a into LFDT-web3j:main Jan 10, 2025
5 checks passed
@jpnovais
Copy link
Contributor Author

@NickSneo thanks for merging it. When do you think it will be released?

@NickSneo
Copy link
Member

Hey @jpnovais , we will make a release by this month end. Currently we are fixing web3j-android release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants