Skip to content

Fixing URLs and branches #2086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Conversation

Julius278
Copy link
Contributor

@Julius278 Julius278 commented Jul 30, 2024

What does this PR do?

fix for new URL (web3j to hyperledger) including one branch fix (master to main)

Where should the reviewer start?

doesn't matter, changes are indenpendent for each class / file

Why is it needed?

branch name and repository owner changed

Checklist

  • I've read the contribution guidelines.
  • I've added tests (if applicable).
  • I've added a changelog entry if necessary.

@Julius278 Julius278 mentioned this pull request Jul 30, 2024
3 tasks
@Julius278
Copy link
Contributor Author

comparable adjustments as @NickSneo did in #2028

@Julius278
Copy link
Contributor Author

Test pipeline: https://github.com/Julius278/web3j/actions/runs/10162422088

no new tests needed, and I would guess no changelog addition needed

Copy link
Member

@NickSneo NickSneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, these are all auto generated code, so it is not really required to change code in every file, we can anyways generate those and replace with new one. But thanks for your efforts.

@Julius278
Copy link
Contributor Author

Hey Nick, yes most of them are auto generated and could be removed from the merge request. But some changes like the README or Generator.java are changes that will make a difference.

Also I would suggest creating a class which holds the code comment String to not have duplicated code in case they are all identical. If you want, I could check that.

@NickSneo
Copy link
Member

Hey Nick, yes most of them are auto generated and could be removed from the merge request. But some changes like the README or Generator.java are changes that will make a difference.

Also I would suggest creating a class which holds the code comment String to not have duplicated code in case they are all identical. If you want, I could check that.

Sure, you can look into it and create a PR we are happy to review

Copy link
Member

@NickSneo NickSneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickSneo NickSneo merged commit b73dba0 into LFDT-web3j:main Jul 30, 2024
5 checks passed
@Julius278 Julius278 deleted the url-branch-fix branch September 23, 2024 11:47
shashankiitbhu pushed a commit to shashankiitbhu/web3j that referenced this pull request Dec 2, 2024
…er to main) (LFDT-web3j#2086)

Signed-off-by: Julius Lauterbach <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
shashankiitbhu pushed a commit to shashankiitbhu/web3j that referenced this pull request Dec 2, 2024
…er to main) (LFDT-web3j#2086)

Signed-off-by: Julius Lauterbach <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
shashankiitbhu pushed a commit to shashankiitbhu/web3j that referenced this pull request Dec 3, 2024
…er to main) (LFDT-web3j#2086)

Signed-off-by: Julius Lauterbach <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
shashankiitbhu pushed a commit to shashankiitbhu/web3j that referenced this pull request Dec 3, 2024
…er to main) (LFDT-web3j#2086)

Signed-off-by: Julius Lauterbach <[email protected]>
Signed-off-by: Shashank Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants