-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Fixing URLs and branches #2086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing URLs and branches #2086
Conversation
…er to main) Signed-off-by: Julius Lauterbach <[email protected]>
Test pipeline: https://github.com/Julius278/web3j/actions/runs/10162422088 no new tests needed, and I would guess no changelog addition needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, these are all auto generated code, so it is not really required to change code in every file, we can anyways generate those and replace with new one. But thanks for your efforts.
Hey Nick, yes most of them are auto generated and could be removed from the merge request. But some changes like the README or Generator.java are changes that will make a difference. Also I would suggest creating a class which holds the code comment String to not have duplicated code in case they are all identical. If you want, I could check that. |
Sure, you can look into it and create a PR we are happy to review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…er to main) (LFDT-web3j#2086) Signed-off-by: Julius Lauterbach <[email protected]> Signed-off-by: Shashank Kumar <[email protected]>
…er to main) (LFDT-web3j#2086) Signed-off-by: Julius Lauterbach <[email protected]> Signed-off-by: Shashank Kumar <[email protected]>
…er to main) (LFDT-web3j#2086) Signed-off-by: Julius Lauterbach <[email protected]> Signed-off-by: Shashank Kumar <[email protected]>
…er to main) (LFDT-web3j#2086) Signed-off-by: Julius Lauterbach <[email protected]> Signed-off-by: Shashank Kumar <[email protected]>
What does this PR do?
fix for new URL (web3j to hyperledger) including one branch fix (master to main)
Where should the reviewer start?
doesn't matter, changes are indenpendent for each class / file
Why is it needed?
branch name and repository owner changed
Checklist