Skip to content

Add Sign.signatureDataFromHex #1916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 2, 2023
Merged

Conversation

zhanxin-xu
Copy link
Contributor

What does this PR do?

Add a function to convert hexadecimal signature to Sign.SignatureData instance

Where should the reviewer start?

There is just a one file.

Why is it needed?

Convert hexadecimal signature to Sign.SignatureData instance

@zhanxin-xu zhanxin-xu requested a review from conor10 as a code owner June 11, 2023 14:32
@NickSneo
Copy link
Member

NickSneo commented Aug 2, 2023

@1329576606 The pipeline is failing, maybe you will need to do spotlessApply

Copy link
Member

@NickSneo NickSneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickSneo NickSneo merged commit c88d5fa into LFDT-web3j:master Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants