Add eip-2930 transaction decoding #1807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dancoombs
force-pushed
the
eip2930-decode
branch
from
853a2f1 to
8d90d7b
Compare
|
hi @dancoombs have you been able to reproduce the falling integration tests locally? |
@mohamedelshami I have not been able to reproduce. It looks like it was a read timeout trying to access maven, likely unrelated to the PR. |
|
hey @mohamedelshami - bump on this! |
andrii-kl
reviewed
Jan 5, 2023
hoanglamcoin
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for EIP-2930 (type 1) transaction encoding/decoding.
Where should the reviewer start?
All code is additive and should be reviewed. There may be some areas where DRY patterns can be used better. Also would love suggestions on where to put the
AccessListObjectas its currently just copied from its original location.Why is it needed?
Support is missing for this transaction type. This PR allows the
TransactionDecoderto handle all transaction types.