Skip to content

chore: fix dev admisison webhook config #6127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Jun 4, 2024

What this PR does / why we need it:

This PR fixes the dev admission webhook config. It fixes the certs related errors on admission:

Error from server (InternalError): error when creating kubernetes-ingress-controller/examples/gateway-httproute.yaml": Internal error occurred: failed calling webhook "validations.kong.konghq.com": failed to call webhook: Post "https://kong-validation-webhook.kong.svc:443/?timeout=10s": dial tcp 10.96.120.80:443: connect: connection refused

It also fixes the name of the admission webhook service.

Additionally it changes the admission webhook policy to Fail: the reason for this change is to allow devs to find errors, related to admission sooner and do not allow them to silently pass through manual validation.

Discovered these problems when working on #6126 and using make run.skaffold SKAFFOLD_RUN_PROFILE=multi_gw for dev environment.

@pmalek pmalek self-assigned this Jun 4, 2024
@pmalek pmalek requested a review from a team as a code owner June 4, 2024 14:13
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.9%. Comparing base (aaf22bf) to head (36f8b60).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #6127     +/-   ##
=======================================
+ Coverage   73.6%   73.9%   +0.2%     
=======================================
  Files        197     197             
  Lines      19167   19382    +215     
=======================================
+ Hits       14113   14329    +216     
+ Misses      4077    4076      -1     
  Partials     977     977             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmalek pmalek merged commit bc75c4f into main Jun 4, 2024
50 checks passed
@pmalek pmalek deleted the fix-dev-admission-webhook-config branch June 4, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants