feat: support NodePort as ingress service type for DataPlane #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sandromodarelli
force-pushed
the
add-nodeport-to-dataplane-servicetype
branch
2 times, most recently
from
e2033b5 to
14bece7
Compare
pmalek
reviewed
Mar 27, 2025
There was a problem hiding this comment.
This looks good. While we're at it, let's add the CRD validation test in https://github.com/Kong/kubernetes-configuration/blob/c5a48eef969febf2f6f3920b5d0861725468dc7e/test/crdsvalidation/gateway-operator.konghq.com/dataplane_test.go which checks that setting the allowed values is indeed possible.
pmalek
approved these changes
Mar 28, 2025
sandromodarelli
force-pushed
the
add-nodeport-to-dataplane-servicetype
branch
3 times, most recently
from
983bfbe to
4caa796
Compare
czeslavo
approved these changes
Mar 28, 2025
czeslavo
force-pushed
the
add-nodeport-to-dataplane-servicetype
branch
from
4caa796 to
2f18b43
Compare
czeslavo
force-pushed
the
add-nodeport-to-dataplane-servicetype
branch
from
2f18b43 to
04c84cb
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
add support for
NodePortas ingress service type for DataPlaneWhich issue this PR fixes
Fixes Kong/gateway-operator#1407
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes