feat: expose crdvalidation testsuite types: TestCasesGroup and TestCases #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
1 task
pmalek
force-pushed
the
export-crdvalidation-testcase-types
branch
from
2dffc64 to
b1e061d
Compare
|
Good! One thing to consider, maybe all those YAMLs should be covered by |
programmer04
approved these changes
Jan 10, 2025
That might make sense. Even though those are quire important to review on a PR they are generate to it's a good idea. Let me handle that in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Expose crdvalidation testsuite types:
TestCasesGroupandTestCasesso that they can be used outside of kcfg repo (e.g. in KGO CRD validation tests).xref: Kong/gateway-operator#984 (comment)
Release 1.0.5
Which issue this PR fixes
Fixes #
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes