-
Notifications
You must be signed in to change notification settings - Fork 128
feat(render): add new command to render final file #963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #963 +/- ##
==========================================
- Coverage 34.06% 33.95% -0.12%
==========================================
Files 100 101 +1
Lines 12106 12214 +108
==========================================
+ Hits 4124 4147 +23
- Misses 7588 7666 +78
- Partials 394 401 +7
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this PR still need all the changes to the convert
package now that an entire new command (render
) has been added?
I removed the duplicate code from |
625abed
to
57734db
Compare
moved this to the 1.25 milestone (was 1.24) |
a0c7951
to
05e47cb
Compare
@GGabriele @zekth rebased and squashed. Should be ready to go now. |
Co-authored-by: Vincent Le Goff <[email protected]>
recovers #874 including tests