Skip to content

fix: return error when sync context ends #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 30, 2021
Merged

fix: return error when sync context ends #529

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
837046a
fix: return error when sync context ends
Nov 23, 2021
d5d0472
Update diff/diff.go
Nov 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions diff/diff.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,6 +477,7 @@ func (sc *Syncer) Run(ctx context.Context, parallelism int, d Do) []error {
var errs []error
select {
case <-ctx.Done():
errs = append(errs, fmt.Errorf("sync context ended, some entities were not synced: %w", ctx.Err()))
case err, ok := <-sc.errChan:
if ok && err != nil {
if err != errEnqueueFailed {
Expand Down