feat: implement dynamic defaulting feature #419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbagdi
force-pushed
the
feat/configurable-defaults
branch
from
81e4eeb to
12ffa12
Compare
mflendrich
approved these changes
May 27, 2021
hbagdi
force-pushed
the
feat/configurable-defaults
branch
2 times, most recently
from
cdf4097 to
f54ba9f
Compare
This was referenced May 27, 2021
rainest
approved these changes
May 27, 2021
hbagdi
force-pushed
the
feat/configurable-defaults
branch
from
f54ba9f to
18e91b5
Compare
- file/codegen/main.go and corresponding schema change
This is to relax the schema of kong entities that are used as input
for defaults. The relaxation is necessary as otherwise the user will
have to specify a name in default values. This doesn't have any
side-effects because the *kong.Type is not used anywhere else in
Content.
- file/builder.go file/reader.go
- defaulter instantiation has been moved inside builder, this feels
natural, defaulter being instantiated outside the builder seems odd
and the only explanation is that I simply didn't think through when
implementing defaulter
- other changes override the default values that are registered
Fix #89
hbagdi
force-pushed
the
feat/configurable-defaults
branch
from
18e91b5 to
ac8961e
Compare
hbagdi
added a commit
that referenced
this pull request
Jun 3, 2021
AntoineJac
pushed a commit
that referenced
this pull request
Jan 23, 2024
- file/codegen/main.go and corresponding schema change
This is to relax the schema of kong entities that are used as input
for defaults. The relaxation is necessary as otherwise the user will
have to specify a name in default values. This doesn't have any
side-effects because the *kong.Type is not used anywhere else in
Content.
- file/builder.go file/reader.go
- defaulter instantiation has been moved inside builder, this feels
natural, defaulter being instantiated outside the builder seems odd
and the only explanation is that I simply didn't think through when
implementing defaulter
- other changes override the default values that are registered
Fix #89
AntoineJac
pushed a commit
that referenced
this pull request
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to relax the schema of kong entities that are used as input
for defaults. The relaxation is necessary as otherwise the user will
have to specify a name in default values. This doesn't have any
side-effects because the *kong.Type is not used anywhere else in
Content.
natural, defaulter being instantiated outside the builder seems odd
and the only explanation is that I simply didn't think through when
implementing defaulter
Fix #89