update custom token url #2875
Merged
update custom token url #2875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
CharlVS
approved these changes
Jul 7, 2025
There was a problem hiding this comment.
TYSM
@takenagain, please take care of SMK's suggested investigations before the next release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some reports of the "custom token import" failing, I did a check of valid urls to confirm our code was correct.
The only change was for bsc, and I set some others to null where I was unable to get a valid url from known contracts on a network and a variety of "platform" values (e.g. ftm, fantom, ftm20 etc).
When building this locally to test, I was still unable to import tokens, despite using the contract in the url comments in this PR, so there appears to be a deeper issue, or perhaps this is dead code, and the logic needing a change is in the Flutter DeFi SDK repo.
This error message may be improved to say "No token info found for contract in CoinGecko API", and a log in the console with full url for further debugging.
Curiously, while testing my PR, I was unable to find the expected coingecko api url in either the console or network tabs or my browser.
@CharlVS @takenagain @TazzyMeister I invite you to further investigate and offer a solution.