-
Notifications
You must be signed in to change notification settings - Fork 230
fix(wallet): fix wallet page jank during coin activation #2806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Visit the preview URL for this PR (updated for commit 4e5b8d5): https://walletrc--pull-2806-merge-wrugm4gp.web.app (expires Tue, 08 Jul 2025 14:28:48 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc |
I'm not going to run Ok, so I log in with the CI branch. Is it faster? Hard to say, utxo came up fast, waited a bit more for EMVs. Repeated the process on prod, which had a few extra coins active, but didnt seem to take significantly longer. All I can say with confidence is that this PR does not break login. Please suggest additional tests to assist with finding a tangible reason to approve this PR. |
Summary
Testing
flutter pub get --offline --enforce-lockfile
(fails: version solving failed)flutter analyze
(fails: version solving failed)https://chatgpt.com/codex/tasks/task_e_68559334727c83268a1a79bf91ce8b32