-
Notifications
You must be signed in to change notification settings - Fork 230
feat(swap): Implement maker fallback in TakerBloc #2709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Visit the preview URL for this PR (updated for commit 7825949): https://walletrc--pull-2709-merge-upml282p.web.app (expires Mon, 23 Jun 2025 16:49:04 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc |
f87df4d
to
7825949
Compare
* fix(dex): refactor maker fallback logging * refactor(dex-repository): using logging package and reduce best orders * fix: rebase duplication and formatting issues
7825949
to
e8a71df
Compare
TODO:
Summary
DexRepository
withsetPrice
helperTakerBloc
to fetch latest orders before submittingsetPrice
setPrice
response and return order UUIDLogger
inTakerBloc
and implement helper wait functionTesting
dart format lib/bloc/dex_repository.dart lib/bloc/taker_form/taker_bloc.dart
flutter analyze lib/bloc/dex_repository.dart lib/bloc/taker_form/taker_bloc.dart