Skip to content

add nomics charts #1789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Jun 16, 2022
Merged

add nomics charts #1789

merged 30 commits into from
Jun 16, 2022

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Jun 12, 2022

closes #1420 and #1732

Current implementation the chart area is too small for the chart.

image

@smk762 smk762 requested review from a user, tonymorony, cipig and Canialon June 12, 2022 08:55
@smk762 smk762 marked this pull request as draft June 12, 2022 08:55
@smk762
Copy link
Collaborator Author

smk762 commented Jun 12, 2022

moved chart to tab
image

@smk762 smk762 marked this pull request as ready for review June 12, 2022 12:28
@smk762
Copy link
Collaborator Author

smk762 commented Jun 13, 2022

To best use the space available, I've removed the "Exchange rates" tab and moved the "priceline" to display under the chart
image

@smk762 smk762 merged commit f212e0d into dev Jun 16, 2022
@tonymorony tonymorony mentioned this pull request Jun 21, 2022
@ghost ghost deleted the nomics_charts branch September 15, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST]: add nomics charts
2 participants