Use Home Assistant's device_class #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixtriller
changed the title
|
Thanks @felixtriller! I was still trying to figure out how to test this as it's a Docker addon and I have no idea how to do that :-) |
|
I updated the unit for |
Koenkk
reviewed
Oct 24, 2018
lib/homeassistant.js
Outdated
| @@ -157,7 +157,7 @@ const configurations = { | |||
| type: 'sensor', | |||
| object_id: 'lock', | |||
| discovery_payload: { | |||
| icon: 'mdi:lock', | |||
| device_class: 'lock', | |||
There was a problem hiding this comment.
Device class lock does not exist for sensor: https://www.home-assistant.io/components/sensor/#device-class (only for binary sensor). Could you revert this?
|
Thanks! |
|
Thank you for your work on this project! If anyone wonders, you have to restart Home Assistant to get the new config from discovery. |
wilmardo
pushed a commit
to wilmardo/zigbee2mqtt
that referenced
this pull request
Sep 26, 2019
* Use Home Assistant's device_class for sensors. * Unit for pressure should be hPa * There is no device_class lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @RodBr wrote in #522 we should use
device_classto have the default appearance in Home Assistant.I am not sure about
sensor_click,sensor_power,sensor_actionandsensor_brightness.Available device classes can be found here and here.