Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unix socket support for the frontend #17123

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Add unix socket support for the frontend #17123

merged 1 commit into from
Mar 23, 2023

Conversation

oddlama
Copy link
Contributor

@oddlama oddlama commented Mar 23, 2023

This PR adds support for starting the frontend on a unix socket. This may be preferable to some users since this allows access to the socket to be restricted to specific processes (nginx). It would be awesome if this feature can be added to z2m ❤️

@oddlama
Copy link
Contributor Author

oddlama commented Mar 23, 2023

I'll be adding tests now.

@Koenkk
Copy link
Owner

Koenkk commented Mar 23, 2023

Could you also make a pr for the docs?

@oddlama
Copy link
Contributor Author

oddlama commented Mar 23, 2023

Sure thing

@oddlama
Copy link
Contributor Author

oddlama commented Mar 23, 2023

Done :) - Btw I'm unsure why CI / tests (macos-latest, 18) (pull_request) Failing after 4m this one specifically failed. Looks like a fluke to me.

Koenkk added a commit to Koenkk/zigbee2mqtt.io that referenced this pull request Mar 23, 2023
* Document use of unix sockets for Koenkk/zigbee2mqtt#17123

* Update frontend.md

---------

Co-authored-by: Koen Kanters <[email protected]>
@Koenkk Koenkk enabled auto-merge (squash) March 23, 2023 16:08
@Koenkk
Copy link
Owner

Koenkk commented Mar 23, 2023

Thanks!

@Koenkk Koenkk disabled auto-merge March 23, 2023 16:08
@Koenkk Koenkk merged commit 07d238d into Koenkk:dev Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants