Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added moving state to home assistant for TS130F Curtain/blind switch #16017

Merged
merged 1 commit into from
Jan 8, 2023

Conversation

cmiguelcabral
Copy link
Contributor

Does this seem less intrusive?

I would like to have someone with different covers test this version.
But people need to be willing to do it as I have more than 30 covers of this model, but don't have any other.

@cmiguelcabral cmiguelcabral force-pushed the ts130f_compatibility branch 3 times, most recently from 92436d3 to 7d53a5f Compare January 7, 2023 23:49
@Koenkk Koenkk merged commit 17fd0ca into Koenkk:master Jan 8, 2023
@Koenkk
Copy link
Owner

Koenkk commented Jan 8, 2023

Thanks, asked for validation in #15873 (comment)

@cmiguelcabral
Copy link
Contributor Author

Thanks, asked for validation in #15873 (comment)

Don't you intend to integrate this into the master?

@Koenkk
Copy link
Owner

Koenkk commented Jan 21, 2023

@cmiguelcabral dev will be merged to master with every new 1st of the month release.

@cmiguelcabral
Copy link
Contributor Author

@cmiguelcabral dev will be merged to master with every new 1st of the month release.

Hi,
Yes, I know, it's not what I meant.
I meant to ask if you intend to integrate this on zigbee2mqtt. :-)

@Koenkk
Copy link
Owner

Koenkk commented Jan 22, 2023

@cmiguelcabral yes, the changes are already in the dev branch since 8 Jan: 9c4abb6

@Drafteed
Copy link
Contributor

I don't really understand the purpose of this change - we introduce a duplicate state. Why not just rename the moving to motor_state in TS130F Curtain/blind?

@Drafteed
Copy link
Contributor

Drafteed commented Jan 23, 2023

Or we could also do this by changing just one line:

const motorState = allExposes?.find((e) => e.type === 'enum' && 
    ['motor_state', 'moving'].includes(e.name) && e.access === ACCESS_STATE);

@Drafteed
Copy link
Contributor

#16324

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants