-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added moving state to home assistant for TS130F Curtain/blind switch #16017
Conversation
92436d3
to
7d53a5f
Compare
7d53a5f
to
17eb3c4
Compare
Thanks, asked for validation in #15873 (comment) |
Don't you intend to integrate this into the master? |
@cmiguelcabral dev will be merged to master with every new 1st of the month release. |
Hi, |
@cmiguelcabral yes, the changes are already in the dev branch since 8 Jan: 9c4abb6 |
I don't really understand the purpose of this change - we introduce a duplicate state. Why not just rename the |
Or we could also do this by changing just one line: const motorState = allExposes?.find((e) => e.type === 'enum' &&
['motor_state', 'moving'].includes(e.name) && e.access === ACCESS_STATE); |
Does this seem less intrusive?
I would like to have someone with different covers test this version.
But people need to be willing to do it as I have more than 30 covers of this model, but don't have any other.