fix!: Refactor onEvent #9650
Open
fix!: Refactor onEvent #9650
+1,120
−1,898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And merge with Koenkk/zigbee-herdsman#1459 & #9679 too for break grouping 😬 |
Nerivec
reviewed
Jul 26, 2025
| deviceExposesChanged: () => void; | ||
| } | ||
| export namespace OnEvent { | ||
| export type BaseData = {device: Zh.Device; deviceExposesChanged: () => void; state: KeyValue; options: KeyValue}; |
There was a problem hiding this comment.
How about naming this DeviceData to avoid confusion? (Also fits with the fact it's only used when the event is device[...].)
With breaking I meant the zhc api breaking (causing a new major zhc release), AFAIK #9679 doesn't break the zhc api? |
|
External converters could be using the cluster name (it's the ZH part that's technically breaking though). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
onEvent:messageonEvent event, existing usages have been refactored to fromZigbee convertersThis is a breaking change, clients have to update the
onEventcalls according to the new types and have to make sure that thestartevent is always emitted before any other event on thedefinition.onEvent().To be merged together with #9693 to prevent 2 breaking change releases in a row.
TODO:
onEvent()and fixonEvent(stop)not being called when device is force removed zigbee2mqtt#27984)