Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set sunricher light configureReporting default was true #9110

Merged
merged 2 commits into from
Apr 2, 2025
Merged

fix: set sunricher light configureReporting default was true #9110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6103d52
fix: set sunricher light default reporting
niracler Apr 2, 2025
bcfdc33
fix: HK-ZD-DIM-A support externalSwitchType
niracler Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/devices/iluminize.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ export const definitions: DefinitionWithExtend[] = [
vendor: "Iluminize",
whiteLabel: [{vendor: "Sunricher", model: "HK-ZD-RGBCCT-A"}],
description: "Zigbee 3.0 universal LED-controller, 5 channel, RGBCCT LED",
extend: [m.light({colorTemp: {range: undefined}, color: true})],
extend: [m.light({colorTemp: {range: undefined}, color: true, configureReporting: true})],
},
{
zigbeeModel: ["ZG2819S-RGBW"],
Expand Down
16 changes: 8 additions & 8 deletions src/devices/sunricher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,14 +477,14 @@ export const definitions: DefinitionWithExtend[] = [
model: "SR-ZG2835RAC-UK",
vendor: "Sunricher",
description: "Push compatible zigBee knob smart dimmer",
extend: [m.light(), m.electricityMeter(), sunricher.extend.externalSwitchType()],
extend: [m.light({configureReporting: true}), m.electricityMeter(), sunricher.extend.externalSwitchType()],
},
{
zigbeeModel: ["ZG2837RAC-K4"],
model: "SR-ZG2835RAC-NK4",
vendor: "Sunricher",
description: "4-Key zigbee rotary & push button smart dimmer",
extend: [m.light(), m.electricityMeter(), m.commandsScenes()],
extend: [m.light({configureReporting: true}), m.electricityMeter(), m.commandsScenes()],
},
{
zigbeeModel: ["HK-ZRC-K5&RS-TL"],
Expand Down Expand Up @@ -751,7 +751,7 @@ export const definitions: DefinitionWithExtend[] = [
access: "ALL",
}),
m.deviceEndpoints({endpoints: {"1": 1, "2": 2, "3": 3}}),
m.light(),
m.light({configureReporting: true}),
m.occupancy({endpointNames: ["2"]}),
m.illuminance({endpointNames: ["3"]}),
m.commandsOnOff(),
Expand Down Expand Up @@ -895,7 +895,7 @@ export const definitions: DefinitionWithExtend[] = [
model: "HK-ZD-CCT-A",
vendor: "Sunricher",
description: "50W Zigbee CCT LED driver (constant current)",
extend: [m.light({colorTemp: {range: [160, 450]}})],
extend: [m.light({colorTemp: {range: [160, 450]}, configureReporting: true})],
},
{
zigbeeModel: ["ZGRC-KEY-004"],
Expand Down Expand Up @@ -1052,7 +1052,7 @@ export const definitions: DefinitionWithExtend[] = [
model: "ZG192910-4",
vendor: "Sunricher",
description: "Zigbee LED-controller",
extend: [m.light({colorTemp: {range: undefined}})],
extend: [m.light({colorTemp: {range: undefined}, configureReporting: true})],
},
{
zigbeeModel: ["ZG9101SAC-HP"],
Expand Down Expand Up @@ -1107,21 +1107,21 @@ export const definitions: DefinitionWithExtend[] = [
model: "SRP-ZG9105-CC",
vendor: "Sunricher",
description: "Constant Current Zigbee LED dimmable driver",
extend: [m.light()],
extend: [m.light({configureReporting: true}), sunricher.extend.externalSwitchType()],
},
{
fingerprint: [{modelID: "HK-ZD-DIM-A", softwareBuildID: "2.9.2_r72"}],
model: "SR-ZG9101CS",
vendor: "Sunricher",
description: "Constant Current Zigbee LED dimmable driver",
extend: [m.light({configureReporting: true})],
extend: [m.light({configureReporting: true}), sunricher.extend.externalSwitchType()],
},
{
zigbeeModel: ["HK-DIM"],
model: "50208702",
vendor: "Sunricher",
description: "LED dimmable driver",
extend: [m.light()],
extend: [m.light({configureReporting: true})],
whiteLabel: [{vendor: "Yphix", model: "50208702"}],
toZigbee: [sunricher.tz.setModel],
// Some ZG9030A-MW devices were mistakenly set with the modelId HK-DIM during manufacturing.
Expand Down