Skip to content

Update sunricher.ts #9080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 30, 2025
Merged

Update sunricher.ts #9080

merged 4 commits into from
Mar 30, 2025

Conversation

chris-1243
Copy link
Contributor

Add new SR-ZG9101CS

CC: @greekgremlin

Add new SR-ZG9101CS
@chris-1243
Copy link
Contributor Author

@Koenkk Open question as I am stuck on that. How may I override the default reporting value set when adding configureReporting: true ?

@Koenkk
Copy link
Owner

Koenkk commented Mar 27, 2025

@chris-1243 why do you want to override the defaults? (there should be a good reason to differ for this device, as we want to keep a consistent reporting across devices)

@chris-1243
Copy link
Contributor Author

chris-1243 commented Mar 27, 2025

In my point of view, the min rep interval for the brightness is a bit too long (10 seconds). I do not have the device. I am helping a user who has this wish. I am fine with default values and we may let each user modifying any values according to their needs as well.

Koenkk/zigbee2mqtt#26818 (comment)

The main reason and to be honest: learning improvement...

@Koenkk
Copy link
Owner

Koenkk commented Mar 27, 2025

I'm fine with changing the default to e.g. 5, but 1 would probably get too spammy

@chris-1243
Copy link
Contributor Author

It is a good compromise. Let's go for it.

Thanks

@Koenkk
Copy link
Owner

Koenkk commented Mar 28, 2025

Would you mind updating the PR with this?

@chris-1243
Copy link
Contributor Author

chris-1243 commented Mar 28, 2025

I am doing something wrong. Would you mind just add the device and disregard all the tries to change the min rep interval. I may also close this PR and just add a new one with the device definition only

@Koenkk Koenkk merged commit 8894142 into Koenkk:master Mar 30, 2025
3 checks passed
@Koenkk
Copy link
Owner

Koenkk commented Mar 30, 2025

I've fixed the test, thanks!

Could you also submit a picture for the docs? This can be done by:

  1. Create a fork by clicking here
  2. Go to the public/images/devices directory, Add file -> Upload files
  3. Upload the files and press Commit changes
  4. Press Contribute -> Open pull request -> update title/description -> Create pull request

Make sure that:

  • The filename is SR-ZG9101CS.png
  • The size is 512x512
  • The background is transparent (use e.g. Adobe remove background)

@chris-1243
Copy link
Contributor Author

chris-1243 commented Mar 30, 2025

Thanks for the test. I was not aware I should also modify this one.

The picture has been already added according to this Koenkk/zigbee2mqtt.io#3638 and merged in zigbee2mqtt.io. It is available in the main branch of zigbee2mqtt.io https://github.com/Koenkk/zigbee2mqtt.io/blob/master/public/images/devices/SR-ZG9101CS.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants