-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Update sunricher.ts #9080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sunricher.ts #9080
Conversation
Add new SR-ZG9101CS
@Koenkk Open question as I am stuck on that. How may I override the default reporting value set when adding |
@chris-1243 why do you want to override the defaults? (there should be a good reason to differ for this device, as we want to keep a consistent reporting across devices) |
In my point of view, the Koenkk/zigbee2mqtt#26818 (comment) The main reason and to be honest: learning improvement... |
I'm fine with changing the default to e.g. 5, but 1 would probably get too spammy |
It is a good compromise. Let's go for it. Thanks |
Would you mind updating the PR with this? |
I am doing something wrong. Would you mind just add the device and disregard all the tries to change the |
I've fixed the test, thanks! Could you also submit a picture for the docs? This can be done by:
Make sure that:
|
Thanks for the test. I was not aware I should also modify this one. The picture has been already added according to this Koenkk/zigbee2mqtt.io#3638 and merged in zigbee2mqtt.io. It is available in the main branch of zigbee2mqtt.io https://github.com/Koenkk/zigbee2mqtt.io/blob/master/public/images/devices/SR-ZG9101CS.png |
Add new SR-ZG9101CS
CC: @greekgremlin