Skip to content

Smoke and heat alarm fixes for table full error (SMSZB-120 and HESZB-120) #8189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Smoke and heat alarm fixes for table full error (SMSZB-120 and HESZB-120) #8189

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0b9ecc
Smoke and heat alarm fixes for table full error
mamrai1 Oct 25, 2024
56c50b7
u
Koenkk Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions src/devices/develco.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,13 @@ const definitions: DefinitionWithExtend[] = [
configure: async (device, coordinatorEndpoint) => {
const endpoint = device.getEndpoint(35);

await reporting.bind(endpoint, coordinatorEndpoint, ['ssIasZone', 'ssIasWd', 'genBasic', 'genBinaryInput']);
// Device supports only 4 binds (otherwise you get TABLE_FULL error)
// https://github.com/Koenkk/zigbee2mqtt/issues/23684
if (endpoint.binds.some((b) => b.cluster.name === 'genPollCtrl')) {
await device.getEndpoint(1).unbind('genPollCtrl', coordinatorEndpoint);
}

await reporting.bind(endpoint, coordinatorEndpoint, ['ssIasZone', 'ssIasWd']);
await endpoint.read('ssIasZone', ['iasCieAddr', 'zoneState', 'zoneId']);
await endpoint.read('genBinaryInput', ['reliability', 'statusFlags']);
await endpoint.read('ssIasWd', ['maxDuration']);
Expand Down Expand Up @@ -468,16 +474,14 @@ const definitions: DefinitionWithExtend[] = [
configure: async (device, coordinatorEndpoint) => {
const endpoint = device.getEndpoint(35);

// Device returns `ZDP_TABLE_FULL` on bind even though it succeeds
// https://github.com/Koenkk/zigbee2mqtt/issues/22492
for (const cluster of ['ssIasZone', 'ssIasWd', 'genBasic', 'genBinaryInput']) {
try {
await endpoint.bind(cluster, coordinatorEndpoint);
} catch {
logger.debug(`Failed to bind '${cluster}'`, NS);
}
// Device supports only 4 binds (otherwise you get TABLE_FULL error)
// https://github.com/Koenkk/zigbee2mqtt/issues/23684
if (endpoint.binds.some((b) => b.cluster.name === 'genPollCtrl')) {
await device.getEndpoint(1).unbind('genPollCtrl', coordinatorEndpoint);
}

await reporting.bind(endpoint, coordinatorEndpoint, ['ssIasZone', 'ssIasWd']);

await endpoint.read('ssIasZone', ['iasCieAddr', 'zoneState', 'zoneId']);
await endpoint.read('genBinaryInput', ['reliability', 'statusFlags']);
await endpoint.read('ssIasWd', ['maxDuration']);
Expand Down
Loading