Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LIXEE] Add EDF zen WE plus Lundi/Vendredi & fix missing indexes expose #5660

Merged
merged 2 commits into from
Apr 24, 2023
Merged

[LIXEE] Add EDF zen WE plus Lundi/Vendredi & fix missing indexes expose #5660

merged 2 commits into from
Apr 24, 2023

Conversation

Mikado8231
Copy link
Contributor

Fix: expose
EASF04 : HP Week-end
EASF05 : HC Mercredi
EASF06 : HP Mercredi

Add: Edf zen plus WE Lundi & Vendredi by copy of Mercredi

@vk496 ok for you ?

Thanks.

@Mikado8231
[LIXEE] Expose missing indexes stand_SEM_WE_MERCR
fd6e86a 
Only 3 indexes are exposed and others are excluded for "SEM WE MERCREDI".

For EDF zen Plus Mercredi, the six first index are used.
EASF01 to 06

EASF01 : HC Semaine
EASF02 : HP Semaine
EASF03 : HC Week-end
EASF04 : HP Week-end
EASF05 : HC Mercredi
EASF06 : HP Mercredi
@Mikado8231
[LIXEE] Add missing EDF Zen Plus days
fc19516 
Simple copy of Mercredi to cover Edf Zen WE plus days (Lundi & Vendredi)
@Mikado8231
Copy link
Contributor Author

#5194

@Koenkk
Copy link
Owner

Koenkk commented Apr 13, 2023

@vk496 could you review this?

@Mikado8231
Copy link
Contributor Author

@Koenkk any chance to be reviewed and available in the next release?

vk496
vk496 approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@vk496 vk496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fine for me

@Mikado8231
Copy link
Contributor Author

@Koenkk @vk496 thanks you for your jobs 👍

@Koenkk
Copy link
Owner

Koenkk commented Apr 24, 2023

Thanks!

@Koenkk Koenkk merged commit 9fa609e into Koenkk:master Apr 24, 2023
@SilentT-FR
Copy link
Contributor

SilentT-FR commented Jun 5, 2023 •
edited
Loading

I think we can regroup all Standard - Sem WE Lundi/Mercredi/Vendredi tarif all in one because its same index/filter ?

EASF04 : HP Week-end
EASF05 : HC Lundi/Mercredi/Vendredi
EASF06 : HP Lundi/Mercredi/Vendredi

@SilentT-FR
Copy link
Contributor

SilentT-FR commented Jun 5, 2023 •
edited
Loading

And why you have excluded :

EASD02 5173.963kWh
Puissance active totale fournie par le fournisseur (index 02)
EASD03 524.187kWh
Puissance active totale fournie par le fournisseur (index 03)
EASD04 663.137kWh
Puissance active totale fournie par le fournisseur (index 04)

?

in your tarif you have all of it filled

#5194 (comment)

I dont know the difference between "Fournisseur" and "Distributeur" but i think you have excluded this because it's doesn't corresponding with your value

if @fairecasoimeme or @vk496 can help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vk496 vk496 vk496 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mikado8231 @Koenkk @SilentT-FR @vk496