Enable LED management in the 41E2PBSWMZ/356PB2MBTZ 2AX switch #5637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
switch's internal LED state. fixes Koenkk#5635 (Thanks @DanielNagy for the sample code)
Already present in extend.switch
- 41EPBDWCLMZ/354PBDMBTZ (Dimmer) - 41E10PBSWMZ-VW (10AX switch) as suggested by @DanielNagy
Koenkk
reviewed
Apr 8, 2023
Renamed switchIndicator to indicator_mode Renamed enum descriptions Refactored enum exposes into reusable function
|
@Koenkk fyi, those 4 led indication state names were taken from the Clipsal app directly. Your on/off replacement suggestions are rather confusing. |
|
@DanielNagy I agree, reverted it. |
|
Thanks @DanielNagy @linkedupbits ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the ability to manage the switch's internal LED state.
Fixes #5635
(Thanks @DanielNagy for the sample code)
Passes lint