Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMaBiT AV2010/32: allow get/set of hysteresis low and high #5625

Merged
merged 1 commit into from
Apr 2, 2023

Conversation

sjorge
Copy link
Contributor

@sjorge sjorge commented Apr 1, 2023

Completes implementation for Koenkk/zigbee2mqtt#17194

I did not add these to the exposes values, it's something you set once and can forget about. I also don't think a lot of people will want to change the default.

@Koenkk
Copy link
Owner

Koenkk commented Apr 2, 2023

I did not add these to the exposes values, it's something you set once and can forget about. I also don't think a lot of people will want to change the default.

Even if set once, it should be exposed. Otherwise it doesn't end up in the docs (and cannot be set via the frontend) and this becomes an undocumented feature.

@sjorge
Copy link
Contributor Author

sjorge commented Apr 2, 2023

I did not add these to the exposes values, it's something you set once and can forget about. I also don't think a lot of people will want to change the default.

Even if set once, it should be exposed. Otherwise it doesn't end up in the docs (and cannot be set via the frontend) and this becomes an undocumented feature.

I was going to add it to the docs manually like for the ctrlSeqOpr stuff.

I vaguely remember something about having a settings like expose too, perhaps this is something that could be sent that way?

Or is that one only for device options?

@Koenkk
Copy link
Owner

Koenkk commented Apr 2, 2023

I vaguely remember something about having a settings like expose too, perhaps this is something that could be sent that way?

That is only for device options (applied at the z2m side). But a PR for the docs is also fine.

@sjorge
Copy link
Contributor Author

sjorge commented Apr 2, 2023

I’ll refactor this a bit more so it can be one expose entry.

@sjorge sjorge force-pushed the bitron_hysteresis branch from 30229e6 to facd4f5 Compare April 2, 2023 10:05
@sjorge
Copy link
Contributor Author

sjorge commented Apr 2, 2023

Now looks like this
image

@Koenkk
Copy link
Owner

Koenkk commented Apr 2, 2023

Clean, thanks!

@Koenkk Koenkk merged commit 0bacfc9 into Koenkk:master Apr 2, 2023
@sjorge sjorge deleted the bitron_hysteresis branch April 2, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants