Slightly change XY color conversion #5554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically reverts:
Like mentioned in my comment in that PR, this was only changed in one of many places.
They're unsigned 16 bit integers, so the max size is 65535. 0 to 65535 is 65536 (which might be what the specs are talking about?)
As I'm not sure the change was even correct in the first place (and ZHA ended up keeping 65535 + deCONZ also uses this), this PR changes that to match all other mentioned places again (so 65535 again).
This generally shouldn't make a difference, but it's better to be consistent everywhere.