Make hvacThermostat weekly_schedule more user friendly

[sjorge]

Took a while to figure out how this works, did I miss a piece of documentation somewhere?

I also made it more user friendly, before you had to write this:

mosquitto_pub -t zigbee2mqtt/trv/office/set -m '{"weekly_schedule":{"dayofweek":1,"mode":1,"numoftrans":5,"transitions":[{"heatSetpoint":16,"transitionTime":0},{"heatSetpoint":22,"transitionTime":390},{"heatSetpoint":18,"transitionTime":540},{"heatSetpoint":22,"transitionTime":1200},{"heatSetpoint":16,"transitionTime":1320}]}}'

Now you can also (this is backwards compatible) write:

mosquitto_pub -t zigbee2mqtt/trv/office/set -m '{"weekly_schedule":{"dayofweek":"monday","mode":"heat","numoftrans":5,"transitions":[{"heatSetpoint":16,"transitionTime":"00:00"},{"heatSetpoint":22,"transitionTime":"06:30"},{"heatSetpoint":18,"transitionTime":"09:00"},{"heatSetpoint":22,"transitionTime":"20:00"},{"heatSetpoint":16,"transitionTime":"22:00"}]}}'

Which to me is a lot more readable and easier, no more doing minutes since 00:00 calculations for transitionTime, no more wondering if sunday is 0 or 7 for dayofweek, ...

[sjorge]

@Koenkk actually hold off with merging, I've been reading some more in the ZCL and seems dayOfWeek is a bitmask
So you can set it for multiple days, I'll refactor this to take something like.

mosquitto_pub -t zigbee2mqtt/trv/office/set -m '{"weekly_schedule":{"dayofweek":["monday"m "tuesday"],"mode":"heat","numoftrans":5,"transitions":[{"heatSetpoint":16,"transitionTime":"00:00"},{"heatSetpoint":22,"transitionTime":"06:30"},{"heatSetpoint":18,"transitionTime":"09:00"},{"heatSetpoint":22,"transitionTime":"20:00"},{"heatSetpoint":16,"transitionTime":"22:00"}]}}'

But I don't have more time today

For self reference

[sjorge]

Alright, I got it all fixed and retested. The following now works:

mosquitto_pub -t zigbee2mqtt/trv/office/set -m '{"weekly_schedule":{"dayofweek":["monday","tuesday","wednesday","thursday","friday"],"mode":"heat","numoftrans":5,"transitions":[{"transitionTime":"00:00","heatSetpoint":16},{"transitionTime":"06:30","heatSetpoint":20},{"transitionTime":"07:30","heatSetpoint":18},{"transitionTime":"18:00","heatSetpoint":20},{"transitionTime":"22:00","heatSetpoint":16}]}}'
mosquitto_pub -t zigbee2mqtt/trv/office/set -m '{"weekly_schedule":{"dayofweek":["saturday","sunday"],"mode":"heat","numoftrans":3,"transitions":[{"transitionTime":"00:00","heatSetpoint":16},{"transitionTime":"09:00","heatSetpoint":20},{"transitionTime":"22:00","heatSetpoint":16}]}}'

This sets a different schedule for weekdays and for the weekend on my TRV.

You can also do something like:

mosquitto_pub -t zigbee2mqtt/trv/office/set -m '{{"weekly_schedule":{"dayofweek":["saturday","sunday"],"mode":["heat","cool"],"numoftrans":3,"transitions":[{"transitionTime":"00:00","heatSetpoint":16},{"transitionTime":"09:00","heatSetpoint":20},{"transitionTime":"22:00","heatSetpoint":16}]}}'

I could not test the above as all my thermostats/trv's are heating only. But the mode field gets correctly set according to the ZCL.

[sjorge]

Once this gets merged, I think we should add a 'generic' page somewhere on zigbee2mqtt.io about how to write a thermostat schedule payload.

[Koenkk]

@sjorge preferably an expose is added such that this can be configured from the frontend. An example can be found here:

zigbee-herdsman-converters/devices/xiaomi.js

Line 3073 in 2b871e6

exposes.list('schedule', ea.STATE_SET, exposes.composite('dayTime', 'dayTime', exposes.access.STATE_SET)

[sjorge]

That one does not look to match the hvac one at all.

Although this commits should make it easier to add something.

However you can execute it multiple times and it does partial updates on the device as described in the ZCL.

If this turns out to be complex, i still think this is a big improvement even without an exposes value.

But I will see if I can add something.

[Koenkk]

This can already be merged indeed, thanks!