-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SMaBiT AV2010/32 does support cool when configured via ctrlSeqOfOper #5452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` power supply: 2x1,5V AA Size Battery ``` The voltage alarm is set at 25, so the 25-30 range of `3V_2500` is the correct one.
- read ctrlSeqeOfOper, we need this for the dynamic expose data as this dictates if we can be off/heat or off/coolo - read localTemperatureCalibration instead of report, limited reporting slots and you cannot change this on the device itself via input
Koenkk
reviewed
Feb 7, 2023
Koenkk
reviewed
Feb 7, 2023
@Koenkk I'll do some more testing during my lunch break and let you know if everything still looks good. |
All good, still works as expected. After changing ctrlSeqeOfOpr and restarting. |
Koenkk
added a commit
to Koenkk/zigbee2mqtt.io
that referenced
this pull request
Feb 8, 2023
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5399 (comment)
This device will support cool or heat depending on the ctrlSeqOfOper value. The manual it has logic for heating_only and cooling_only.
The device now has a 'dynamic expose' function that returns the correct supported modes based on
ctrlSeqOfOper
. I also added batteryVoltage reading, fixed the battery calculation. I also extendedClimate
expose to add a withCtrlSeweofOper methode.We should update the notes for this device that a restart of z2m is needed after changing ctrlSeqOfOper for the expose data to be updated.