Add more philips effect lights #5312
Conversation
That's fine!
Yes please do so in a new Thanks for your contributions again! |
lib/philips.js
Outdated
| @@ -249,4 +659,9 @@ function encodeGradientColors(value, opts) { | |||
| module.exports = { | |||
| decodeGradientColors, | |||
| encodeGradientColors, | |||
| hueExtend, | |||
There was a problem hiding this comment.
Since this is in philips.js, we can rename this to just extend. (we do the same for TuYa)
devices/philips.js
Outdated
| const e = exposes.presets; | ||
| const ea = exposes.access; | ||
|
|
||
| // Make sure extend.light_* is not used (hueExtend should be used instead) | ||
| // Make sure extend.light_* is not used (philips.hueExtend should be used instead) | ||
| const extendDontUse = require('../lib/extend'); | ||
| const extend = {switch: extendDontUse.switch}; |
There was a problem hiding this comment.
const extendDontUse = require('../lib/extend'); can be removed, when changing const extend = {switch: extendDontUse.switch}; to const extend = {switch: require('../lib/extend').switch};
lib/philips.js
Outdated
| @@ -249,4 +659,9 @@ function encodeGradientColors(value, opts) { | |||
| module.exports = { | |||
| decodeGradientColors, | |||
| encodeGradientColors, | |||
| hueExtend, | |||
| tzLocal, | |||
| fzLocal, | |||
There was a problem hiding this comment.
Local can be dropped (just like TuYa):
zigbee-herdsman-converters/lib/tuya.js
Line 1814 in 75db090
… into more-philips-effect-lights
|
Thanks for the review. All done! |
|
Looks great, thanks! |
This PR adds candle effect support for additional lights.
I have confirmed this works on:
I don't have LWW002 to test with. Since it's the same definition and title as LWA003 I assume it works and it's just a later revision?
As well, for testing this with an external converter required a ton of copy-paste. Would we consider exporting
hueExtend?Finally, I'm not sure if Philips makes lights that are a "bright white" color temperature only. If so, I assume they don't support Candle in which case I think we'd want to change what's
light_onoff_brightnessto something likelight_onoff_warm_brightness.