ubisys: fix C4 actions when non legacy #5281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Should this change also be considered in documentation of actions for c4 accordingly? |
|
This should automatically happen as it parses the expose data (AFAIK) |
|
Looks good, docs are updated automagically. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Koenkk/zigbee2mqtt#15171
Discussion sort of got mixed in with Koenkk/zigbee2mqtt#15875 sadly.
This should bring C4 in line with what S1/S2 report for action.
@Koenkk @Danit2 was wonders if we can just get rid of fz.legacy.ubisys_c4_* and call fz.command_* directly, I'm OK with this but I kept the wrapper around in case someone is somehow still using legacy: true for this device.