Improve ZNCLBL01LM support #5104

mandrean · 2022-12-07T19:43:48Z

New features:

Calibrating limits (start, end, reset)
Opening/closing hooks
Enabling/disabling "pull to open/close"

- Refactor converters - Clearing limits calibration - Opening/closing hooks - Enabling/disabling "pull to open/close"

Koenkk · 2022-12-08T16:22:43Z

devices/xiaomi.js

-                .withDescription('Hooks state'),
+            exposes.enum('motor_state', ea.STATE, ['stopped', 'opening', 'closing', 'pause']).withDescription('Motor state'),
+            exposes.binary('running', ea.STATE, true, false).withDescription('Whether the motor is moving or not'),
+            exposes.enum('hooks_action', ea.SET, ['unlock', 'lock']).withDescription('Hooks action'),


I suggest to change this to action and rename the unlock/lock to hooks_unlock/hooks_lock

Wouldn't that collide somehow with the existing read-only field also called action?

No, since action is not a state (something that has to be persisted).

Koenkk · 2022-12-14T16:43:02Z

converters/toZigbee.js

-        convertGet: async (entity, key, meta) => {
-            await entity.read('aqaraOpple', [0x040B], manufacturerOptions.xiaomi);
+    ZNCLBL01LM_action: {
+        key: ['action'],


I just see now that this a settable thing, then action should not be used, my apologies.

Can we rename this to hooks_lock and then accept the values LOCK and UNLOCK?

We can then use the following expose:

exposes.binary('hooks_lock', ea.STATE_SET, 'LOCK', 'UNLOCK').withDescription('Lock the curtain hooks'),

Better now?

Perfect, I added one more improvement to also have the hooks_lock present in the state. It also changes based on the hooks_action now. Can you check if it works correctly? If yes then this can be merged.

Will check!

@Koenkk Works great!

Do you get motor_state even when it isn't running?

Looks like this when its not running:

And when it runs:

Looks like this when its not running:

Nah, still the same issue in MQTT log:

2023-01-02 10:20:00.421 DEBUG (MainThread) [homeassistant.components.mqtt.client] Received message on zigbee2mqtt/Bedroom Curtain Left: b'{"action":null,"battery":100,"charging":false,"device_temperature":19,"hand_open":null,"hooks_lock":"UNLOCK","hooks_state":"unlocked","last_seen":"2023-01-02T09:20:00.397Z","linkquality":255,"position":83,"power_outage_count":7,"power_source":"battery","running":false,"state":"OPEN","target_position":83,"update":{"installed_version":6168,"latest_version":6168,"state":"idle"},"update_available":false,"voltage":3000}' 2023-01-02 10:20:00.424 DEBUG (MainThread) [homeassistant.components.mqtt.models] Rendering incoming payload '{"action":null,"battery":100,"charging":false,"device_temperature":19,"hand_open":null,"hooks_lock":"UNLOCK","hooks_state":"unlocked","last_seen":"2023-01-02T09:20:00.397Z","linkquality":255,"position":83,"power_outage_count":7,"power_source":"battery","running":false,"state":"OPEN","target_position":83,"update":{"installed_version":6168,"latest_version":6168,"state":"idle"},"update_available":false,"voltage":3000}' with variables {'entity_id': 'switch.bedroom_curtain_left_hand_open', 'name': 'Bedroom Curtain Left hand_open', 'this': <template TemplateStateFromEntityId(switch.bedroom_curtain_left_hand_open)>} and Template("{% if value_json.hand_open %} true {% else %} false {% endif %}") 2023-01-02 10:20:00.425 DEBUG (MainThread) [homeassistant.components.mqtt.models] Rendering incoming payload '{"action":null,"battery":100,"charging":false,"device_temperature":19,"hand_open":null,"hooks_lock":"UNLOCK","hooks_state":"unlocked","last_seen":"2023-01-02T09:20:00.397Z","linkquality":255,"position":83,"power_outage_count":7,"power_source":"battery","running":false,"state":"OPEN","target_position":83,"update":{"installed_version":6168,"latest_version":6168,"state":"idle"},"update_available":false,"voltage":3000}' with variables {'entity_id': 'sensor.bedroom_curtain_left_battery', 'name': 'Bedroom Curtain Left battery', 'this': <template TemplateStateFromEntityId(sensor.bedroom_curtain_left_battery)>} with default value 'default' and Template("{{ value_json.battery }}") 2023-01-02 10:20:00.427 DEBUG (MainThread) [homeassistant.components.mqtt.models] Rendering incoming payload '{"action":null,"battery":100,"charging":false,"device_temperature":19,"hand_open":null,"hooks_lock":"UNLOCK","hooks_state":"unlocked","last_seen":"2023-01-02T09:20:00.397Z","linkquality":255,"position":83,"power_outage_count":7,"power_source":"battery","running":false,"state":"OPEN","target_position":83,"update":{"installed_version":6168,"latest_version":6168,"state":"idle"},"update_available":false,"voltage":3000}' with variables {'entity_id': 'sensor.bedroom_curtain_left_device_temperature', 'name': 'Bedroom Curtain Left device temperature', 'this': <template TemplateStateFromEntityId(sensor.bedroom_curtain_left_device_temperature)>} with default value 'default' and Template("{{ value_json.device_temperature }}") 2023-01-02 10:20:00.428 DEBUG (MainThread) [homeassistant.components.mqtt.models] Rendering incoming payload '{"action":null,"battery":100,"charging":false,"device_temperature":19,"hand_open":null,"hooks_lock":"UNLOCK","hooks_state":"unlocked","last_seen":"2023-01-02T09:20:00.397Z","linkquality":255,"position":83,"power_outage_count":7,"power_source":"battery","running":false,"state":"OPEN","target_position":83,"update":{"installed_version":6168,"latest_version":6168,"state":"idle"},"update_available":false,"voltage":3000}' with variables {'entity_id': 'sensor.bedroom_curtain_left_action', 'name': 'Bedroom Curtain Left action', 'this': <template TemplateStateFromEntityId(sensor.bedroom_curtain_left_action)>} with default value 'default' and Template("{{ value_json.action }}") 2023-01-02 10:20:00.430 DEBUG (MainThread) [homeassistant.components.mqtt.models] Rendering incoming payload '{"action":null,"battery":100,"charging":false,"device_temperature":19,"hand_open":null,"hooks_lock":"UNLOCK","hooks_state":"unlocked","last_seen":"2023-01-02T09:20:00.397Z","linkquality":255,"position":83,"power_outage_count":7,"power_source":"battery","running":false,"state":"OPEN","target_position":83,"update":{"installed_version":6168,"latest_version":6168,"state":"idle"},"update_available":false,"voltage":3000}' with variables {'entity_id': 'sensor.bedroom_curtain_left_motor_state', 'name': 'Bedroom Curtain Left motor state', 'this': <template TemplateStateFromEntityId(sensor.bedroom_curtain_left_motor_state)>} with default value 'default' and Template("{{ value_json.motor_state }}") 2023-01-02 10:20:00.430 WARNING (MainThread) [homeassistant.helpers.template] Template variable warning: 'dict object' has no attribute 'motor_state' when rendering '{{ value_json.motor_state }}' 2023-01-02 10:20:00.435 DEBUG (MainThread) [homeassistant.components.mqtt.models] Rendering incoming payload '{"action":null,"battery":100,"charging":false,"device_temperature":19,"hand_open":null,"hooks_lock":"UNLOCK","hooks_state":"unlocked","last_seen":"2023-01-02T09:20:00.397Z","linkquality":255,"position":83,"power_outage_count":7,"power_source":"battery","running":false,"state":"OPEN","target_position":83,"update":{"installed_version":6168,"latest_version":6168,"state":"idle"},"update_available":false,"voltage":3000}' with variables {'entity_id': 'sensor.bedroom_curtain_left_hooks_state', 'name': 'Bedroom Curtain Left hooks state', 'this': <template TemplateStateFromEntityId(sensor.bedroom_curtain_left_hooks_state)>} with default value 'default' and Template("{{ value_json.hooks_state }}") 2023-01-02 10:20:00.435 DEBUG (MainThread) [homeassistant.components.mqtt.models] Rendering incoming payload '{"action":null,"battery":100,"charging":false,"device_temperature":19,"hand_open":null,"hooks_lock":"UNLOCK","hooks_state":"unlocked","last_seen":"2023-01-02T09:20:00.397Z","linkquality":255,"position":83,"power_outage_count":7,"power_source":"battery","running":false,"state":"OPEN","target_position":83,"update":{"installed_version":6168,"latest_version":6168,"state":"idle"},"update_available":false,"voltage":3000}' with variables {'entity_id': 'sensor.bedroom_curtain_left_target_position', 'name': 'Bedroom Curtain Left target position', 'this': <template TemplateStateFromEntityId(sensor.bedroom_curtain_left_target_position)>} with default value 'default' and Template("{{ value_json.target_position }}") 2023-01-02 10:20:00.436 DEBUG (MainThread) [homeassistant.components.mqtt.models] Rendering incoming payload '{"action":null,"battery":100,"charging":false,"device_temperature":19,"hand_open":null,"hooks_lock":"UNLOCK","hooks_state":"unlocked","last_seen":"2023-01-02T09:20:00.397Z","linkquality":255,"position":83,"power_outage_count":7,"power_source":"battery","running":false,"state":"OPEN","target_position":83,"update":{"installed_version":6168,"latest_version":6168,"state":"idle"},"update_available":false,"voltage":3000}' with variables {'entity_id': 'sensor.bedroom_curtain_left_power_source', 'name': 'Bedroom Curtain Left power source', 'this': <template TemplateStateFromEntityId(sensor.bedroom_curtain_left_power_source)>} with default value 'default' and Template("{{ value_json.power_source }}") 2023-01-02 10:20:00.436 DEBUG (MainThread) [homeassistant.components.mqtt.models] Rendering incoming payload '{"action":null,"battery":100,"charging":false,"device_temperature":19,"hand_open":null,"hooks_lock":"UNLOCK","hooks_state":"unlocked","last_seen":"2023-01-02T09:20:00.397Z","linkquality":255,"position":83,"power_outage_count":7,"power_source":"battery","running":false,"state":"OPEN","target_position":83,"update":{"installed_version":6168,"latest_version":6168,"state":"idle"},"update_available":false,"voltage":3000}' with variables {'entity_id': 'select.bedroom_curtain_left_hooks_lock', 'name': 'Bedroom Curtain Left hooks lock', 'this': <template TemplateStateFromEntityId(select.bedroom_curtain_left_hooks_lock)>} and Template("{{ value_json.hooks_lock }}") 2023-01-02 10:20:00.436 DEBUG (MainThread) [homeassistant.components.mqtt.models] Rendering incoming payload '{"action":null,"battery":100,"charging":false,"device_temperature":19,"hand_open":null,"hooks_lock":"UNLOCK","hooks_state":"unlocked","last_seen":"2023-01-02T09:20:00.397Z","linkquality":255,"position":83,"power_outage_count":7,"power_source":"battery","running":false,"state":"OPEN","target_position":83,"update":{"installed_version":6168,"latest_version":6168,"state":"idle"},"update_available":false,"voltage":3000}' with variables {'entity_id': 'binary_sensor.bedroom_curtain_left_running', 'name': 'Bedroom Curtain Left running', 'this': <template TemplateStateFromEntityId(binary_sensor.bedroom_curtain_left_running)>} and Template("{{ value_json.running }}") 2023-01-02 10:20:00.436 DEBUG (MainThread) [homeassistant.components.mqtt.models] Rendering incoming payload '{"action":null,"battery":100,"charging":false,"device_temperature":19,"hand_open":null,"hooks_lock":"UNLOCK","hooks_state":"unlocked","last_seen":"2023-01-02T09:20:00.397Z","linkquality":255,"position":83,"power_outage_count":7,"power_source":"battery","running":false,"state":"OPEN","target_position":83,"update":{"installed_version":6168,"latest_version":6168,"state":"idle"},"update_available":false,"voltage":3000}' with variables {'entity_id': 'binary_sensor.bedroom_curtain_left_charging', 'name': 'Bedroom Curtain Left charging', 'this': <template TemplateStateFromEntityId(binary_sensor.bedroom_curtain_left_charging)>} and Template("{{ value_json.charging }}") 2023-01-02 10:20:00.437 DEBUG (MainThread) [homeassistant.components.mqtt.models] Rendering incoming payload '{"action":null,"battery":100,"charging":false,"device_temperature":19,"hand_open":null,"hooks_lock":"UNLOCK","hooks_state":"unlocked","last_seen":"2023-01-02T09:20:00.397Z","linkquality":255,"position":83,"power_outage_count":7,"power_source":"battery","running":false,"state":"OPEN","target_position":83,"update":{"installed_version":6168,"latest_version":6168,"state":"idle"},"update_available":false,"voltage":3000}' with variables {'entity_id': 'binary_sensor.bedroom_curtain_left_update_available', 'name': 'Bedroom Curtain Left update available', 'this': <template TemplateStateFromEntityId(binary_sensor.bedroom_curtain_left_update_available)>} and Template("{{ value_json['update']['state'] == "available" }}") 2023-01-02 10:20:00.437 DEBUG (MainThread) [homeassistant.components.mqtt.models] Rendering incoming payload '{"action":null,"battery":100,"charging":false,"device_temperature":19,"hand_open":null,"hooks_lock":"UNLOCK","hooks_state":"unlocked","last_seen":"2023-01-02T09:20:00.397Z","linkquality":255,"position":83,"power_outage_count":7,"power_source":"battery","running":false,"state":"OPEN","target_position":83,"update":{"installed_version":6168,"latest_version":6168,"state":"idle"},"update_available":false,"voltage":3000}' with variables {'position_open': 100, 'position_closed': 0, 'tilt_min': 0, 'tilt_max': 100, 'entity_id': 'cover.bedroom_curtain_left', 'name': 'Bedroom Curtain Left', 'this': <template TemplateStateFromEntityId(cover.bedroom_curtain_left)>} and Template("{{ value_json.position }}") 2023-01-02 10:20:00.437 DEBUG (MainThread) [homeassistant.components.mqtt.models] Rendering incoming payload '{"action":null,"battery":100,"charging":false,"device_temperature":19,"hand_open":null,"hooks_lock":"UNLOCK","hooks_state":"unlocked","last_seen":"2023-01-02T09:20:00.397Z","linkquality":255,"position":83,"power_outage_count":7,"power_source":"battery","running":false,"state":"OPEN","target_position":83,"update":{"installed_version":6168,"latest_version":6168,"state":"idle"},"update_available":false,"voltage":3000}' with variables {'entity_id': 'update.bedroom_curtain_left', 'name': 'Bedroom Curtain Left', 'this': <template TemplateStateFromEntityId(update.bedroom_curtain_left)>} and Template("{{ value_json['update']['installed_version'] }}") 2023-01-02 10:20:00.437 DEBUG (MainThread) [homeassistant.components.mqtt.update] Non-dictionary JSON payload detected after processing payload '6168' on topic zigbee2mqtt/Bedroom Curtain Left 2023-01-02 10:20:00.438 DEBUG (MainThread) [homeassistant.components.mqtt.models] Rendering incoming payload '{"action":null,"battery":100,"charging":false,"device_temperature":19,"hand_open":null,"hooks_lock":"UNLOCK","hooks_state":"unlocked","last_seen":"2023-01-02T09:20:00.397Z","linkquality":255,"position":83,"power_outage_count":7,"power_source":"battery","running":false,"state":"OPEN","target_position":83,"update":{"installed_version":6168,"latest_version":6168,"state":"idle"},"update_available":false,"voltage":3000}' with variables {'entity_id': 'cover.bedroom_curtain_left', 'name': 'Bedroom Curtain Left', 'this': <template TemplateStateFromEntityId(cover.bedroom_curtain_left)>} and Template("{{ value_json.motor_state if value_json.motor_state and value_json.motor_state != 'stopped' else value_json.state }}")

Koenkk · 2022-12-17T09:16:14Z

Thanks!

mandrean mentioned this pull request Dec 7, 2022

Improve support for Aqara / Xiaomi Curtain Drivers #4943

Closed

mandrean force-pushed the ZNCLBL01LM_converters branch 2 times, most recently from ef5a09b to f3187ad Compare December 8, 2022 02:24

Improve ZNCLBL01LM support

7333a23

- Refactor converters - Clearing limits calibration - Opening/closing hooks - Enabling/disabling "pull to open/close"

mandrean force-pushed the ZNCLBL01LM_converters branch from f3187ad to 66018ba Compare December 8, 2022 02:26

Apply eslint fix

e272344

mandrean force-pushed the ZNCLBL01LM_converters branch from 66018ba to e272344 Compare December 8, 2022 02:37

Support limits calibration

32d6ee5

mandrean force-pushed the ZNCLBL01LM_converters branch from 3b69f6b to 32d6ee5 Compare December 8, 2022 03:06

Koenkk reviewed Dec 8, 2022

View reviewed changes

buhito81 mentioned this pull request Dec 12, 2022

Xiaomi ZNCLBL01LM: Template variable warning: 'dict object' has no attribute 'motor_state' when rendering '{{ value_json.motor_state }}' Koenkk/zigbee2mqtt#15116

Closed

mandrean force-pushed the ZNCLBL01LM_converters branch from 1c2a64b to 93a5ed0 Compare December 14, 2022 14:27

Koenkk reviewed Dec 14, 2022

View reviewed changes

Rename hooks_action

6be390d

mandrean force-pushed the ZNCLBL01LM_converters branch from 93a5ed0 to 6be390d Compare December 14, 2022 19:36

mandrean requested a review from Koenkk December 15, 2022 09:05

Koenkk added 3 commits December 15, 2022 20:07

Update xiaomi.js

2e8ce65

Update xiaomi.js

27e634c

Update toZigbee.js

9aecc89

Koenkk merged commit 4793794 into Koenkk:master Dec 17, 2022

mandrean deleted the ZNCLBL01LM_converters branch December 17, 2022 09:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Improve ZNCLBL01LM support #5104

Improve ZNCLBL01LM support #5104

Uh oh!

mandrean commented Dec 7, 2022 •

edited

Loading

Uh oh!

Koenkk Dec 8, 2022 •

edited

Loading

Uh oh!

mandrean Dec 9, 2022

Uh oh!

Koenkk Dec 9, 2022

Uh oh!

Koenkk Dec 14, 2022

Uh oh!

mandrean Dec 14, 2022

Uh oh!

Koenkk Dec 15, 2022

Uh oh!

mandrean Dec 16, 2022

Uh oh!

mandrean Dec 16, 2022

Uh oh!

buhito81 Dec 16, 2022

Uh oh!

mandrean Dec 17, 2022

Uh oh!

mandrean Dec 17, 2022

Uh oh!

buhito81 Jan 2, 2023

Uh oh!

Koenkk commented Dec 17, 2022

Uh oh!

Uh oh!

Improve ZNCLBL01LM support #5104

Improve ZNCLBL01LM support #5104

Uh oh!

Conversation

mandrean commented Dec 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Koenkk Dec 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Koenkk commented Dec 17, 2022

Uh oh!

Uh oh!

mandrean commented Dec 7, 2022 •

edited

Loading

Koenkk Dec 8, 2022 •

edited

Loading