reportAttribute modernExtend #8965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reportable lowState for battery modernExtent
Koenkk
reviewed
Mar 10, 2025
src/lib/modernExtend.ts
Outdated
| @@ -454,6 +455,12 @@ export function battery(args?: BatteryArgs): ModernExtend { | |||
| result.meta = meta; | |||
| } | |||
|
|
|||
| if (args.lowStatusReportingConfig) { | |||
| const configure: Configure[] = result.configure || []; | |||
There was a problem hiding this comment.
const result: ModernExtend = {exposes, fromZigbee, toZigbee, isModernExtend: true};
result.configure = []to prevent creating a configure here and under percentageReporting
Koenkk
reviewed
Mar 11, 2025
src/lib/modernExtend.ts
Outdated
| @@ -2686,4 +2691,17 @@ export function bindCluster(args: {cluster: string | number; clusterType: "input | |||
| return {configure, isModernExtend: true}; | |||
| } | |||
|
|
|||
| export function reportAttribute(args: { | |||
There was a problem hiding this comment.
I don't think this is used? Please remove
There was a problem hiding this comment.
currently not used, but can be used along with/like bindCluster modernExtend https://github.com/Koenkk/zigbee-herdsman-converters/blob/master/src/lib/modernExtend.ts#L2684C17
There was a problem hiding this comment.
If it is not used than I propose to remove it for now.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reportable lowState for battery modernExtent