Skip to content

Commit 4d37030

Browse files
fix: Add lowStatusReportingConfig to battery modernExtend (#8965)
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
1 parent 854742e commit 4d37030

File tree

2 files changed

+12
-7
lines changed

2 files changed

+12
-7
lines changed

src/devices/dqsmart.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
const m = require("zigbee-herdsman-converters/lib/modernExtend");
1+
import * as m from "../lib/modernExtend";
22
import type {DefinitionWithExtend} from "../lib/types";
33

44
export const definitions: DefinitionWithExtend[] = [

src/lib/modernExtend.ts

+11-6
Original file line numberDiff line numberDiff line change
@@ -327,6 +327,7 @@ export interface BatteryArgs {
327327
percentageReporting?: boolean;
328328
voltageReportingConfig?: ReportingConfigWithoutAttribute;
329329
voltageReporting?: boolean;
330+
lowStatusReportingConfig?: ReportingConfigWithoutAttribute;
330331
}
331332
export function battery(args?: BatteryArgs): ModernExtend {
332333
// biome-ignore lint/style/noParameterAssign: ignored using `--suppress`
@@ -433,18 +434,18 @@ export function battery(args?: BatteryArgs): ModernExtend {
433434
},
434435
];
435436

436-
const result: ModernExtend = {exposes, fromZigbee, toZigbee, isModernExtend: true};
437+
const result: ModernExtend = {exposes, fromZigbee, toZigbee, configure: [], isModernExtend: true};
437438

438439
if (args.percentageReporting || args.voltageReporting) {
439-
const configure: Configure[] = [];
440440
if (args.percentageReporting) {
441-
configure.push(setupConfigureForReporting("genPowerCfg", "batteryPercentageRemaining", args.percentageReportingConfig, ea.STATE_GET));
441+
result.configure.push(
442+
setupConfigureForReporting("genPowerCfg", "batteryPercentageRemaining", args.percentageReportingConfig, ea.STATE_GET),
443+
);
442444
}
443445
if (args.voltageReporting) {
444-
configure.push(setupConfigureForReporting("genPowerCfg", "batteryVoltage", args.voltageReportingConfig, ea.STATE_GET));
446+
result.configure.push(setupConfigureForReporting("genPowerCfg", "batteryVoltage", args.voltageReportingConfig, ea.STATE_GET));
445447
}
446-
configure.push(configureSetPowerSourceWhenUnknown("Battery"));
447-
result.configure = configure;
448+
result.configure.push(configureSetPowerSourceWhenUnknown("Battery"));
448449
}
449450

450451
if (args.voltageToPercentage || args.dontDividePercentage) {
@@ -454,6 +455,10 @@ export function battery(args?: BatteryArgs): ModernExtend {
454455
result.meta = meta;
455456
}
456457

458+
if (args.lowStatusReportingConfig) {
459+
result.configure.push(setupConfigureForReporting("genPowerCfg", "batteryAlarmState", args.lowStatusReportingConfig, ea.STATE_GET));
460+
}
461+
457462
return result;
458463
}
459464

0 commit comments

Comments
 (0)