Skip to content

Add babel polyfill and upgrade sanity base #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 15, 2022

Conversation

devinhalladay
Copy link
Contributor

@devinhalladay devinhalladay commented Apr 26, 2022

This PR fixes an error when using the plugin with the latest beta update. It upgrades @sanity/base to a more recent stable version to resolve issues with the parts system, and adds @babel/plugin-transform-runtime to resolve this error preventing the hosted package from building correctly.

I was able to test locally by creating another branch and pushing the build directory, then adding the git branch as an npm dependency in my sanity studio project.

Part of #8 but does not close it.

@devinhalladay devinhalladay marked this pull request as ready for review April 26, 2022 20:10
@devinhalladay devinhalladay changed the title [DRAFT] Hotfix/babel transform runtime Add babel polyfill and upgrade sanity base Apr 26, 2022
@devinhalladay
Copy link
Contributor Author

Hi @KimPaow — I know you mentioned being busy these days, so I just wanted to bump this and make sure it is on your radar :) thank you again for your work on this library!

@KimPaow
Copy link
Owner

KimPaow commented May 11, 2022

Thank you for this @devinhalladay! It's on my radar but still super busy, I might be able to take a look this weekend. Again, thanks for this contribution!

@devinhalladay
Copy link
Contributor Author

Bumping this again as a reminder @KimPaow <3

Copy link
Owner

@KimPaow KimPaow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Just need some clarification and I can have it out tomorrow.

@devinhalladay devinhalladay requested a review from KimPaow June 14, 2022 19:17
@KimPaow KimPaow merged commit 8f114ab into KimPaow:master Jun 15, 2022
@KimPaow
Copy link
Owner

KimPaow commented Jun 15, 2022

@devinhalladay published 2.0.3. Thanks for the contribution!

@devinhalladay devinhalladay deleted the hotfix/babel-transform-runtime branch June 16, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants