-
Notifications
You must be signed in to change notification settings - Fork 724
Improve and fix async compute sample #1366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvement, and very helpful comments in async_compute.cpp
!
Just a few comments in the framework part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am seeing some warning with this sample:
[warning] Render Pass creation: size of attachment list and load/store info list does not match: 1 vs 2
[warning] Render Pass creation: size of attachment list and load/store info list does not match: 1 vs 2
It looks like those existed before your change though.
This allow to set a debug name for images for textures
Validation layers configuration options are not ignored
413fd18
to
b542e47
Compare
The warning was present before my changes, but I’ve pushed a fix for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Description
This PR adds missing barriers to the async_compute sample as highlighted by #1331. We have also added comments to the code to better explain how the sample works. A few validation synchronization errors have also been fixed.
When looking at this sample I found some problems in the framework that I also fix in this PR:
old_queue_family
andnew_queue_family
. The async compute sample is the only place using them so I re-enable them and I stop ignoring them. I also renamed them tosrc_queue_family
anddst_queue_family
to be closer to the vulkan spec.VKB_VALIDATION_LAYERS_GPU_ASSISTED
,VKB_VALIDATION_LAYERS_BEST_PRACTICES
andVKB_VALIDATION_LAYERS_SYNCHRONIZATION
were being ignored. I use this chance to update how we control the validation layers, replacingVK_EXT_validation_features
withVK_EXT_layer_settings
. This should close Add sample utilizing VK_EXT_layer_settings #863Tested on Android using a Mali G715 and on Windows using a Nvidia RTX 4070 Super
Fixes #1331 #863
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batch
command line argument to make sure all samples still work properlySample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: