Cleanup command extension checking of device functions #1733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove some TODO's about needing the detailed dependency info of a command. Commands from extensions are available if any of the extensions they come from are enabled. The extensions themselves have complex requirements for enabling, but because the loader tries to do basic validation, it should only check that the primary extensions are available. This is so that the loader doesn't replicate all of the complicated dependency checking logic that already present in the Validation Layer.
|
CI Vulkan-Loader build queued with queue ID 471171. |
|
CI Vulkan-Loader build queued with queue ID 471188. |
|
CI Vulkan-Loader build # 3093 running. |
|
CI Vulkan-Loader build # 3093 failed. |
spencer-lunarg
approved these changes
Jun 23, 2025
|
CI Vulkan-Loader build queued with queue ID 471213. |
|
CI Vulkan-Loader build # 3094 running. |
|
CI Vulkan-Loader build # 3094 failed. |
|
CI Vulkan-Loader build queued with queue ID 471251. |
|
CI Vulkan-Loader build # 3095 running. |
|
CI Vulkan-Loader build # 3095 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some TODO's about needing the detailed dependency info of a command. Commands from extensions are available if any of the extensions they come from are enabled. The extensions themselves have complex requirements for enabling, but because the loader tries to do basic validation, it should only check that the primary extensions are available. This is so that the loader doesn't replicate all of the complicated dependency checking logic that already present in the Validation Layer.