[WB-1896] Add ThunderBlocks theme #2501
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 20 commits
February 26, 2025 17:44
…emantic color tokens as css variables
…ge themes using CSS variables
…h references to css variables. Creates a build step to convert semanticColor tokens to css variables that can be consumed via CSS imports.
🦋 Changeset detectedLatest commit: 45b391a The changes in this PR will be included in the next version bump. This PR includes changesets to release 26 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: 0 B Total Size: 103 kB ℹ️ View Unchanged
|
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-qsjikfxfiw.chromatic.com/ Chromatic results:
|
marcysutton
reviewed
Mar 20, 2025
| @@ -0,0 +1,119 @@ | |||
| import {fade} from "../util/utils"; | |||
There was a problem hiding this comment.
question: Should we put theme tokens into directories to organize them? Now that I'm looking into Typography tokens, I'm noticing this folder could get a bit crowded.
| const black = "#191918"; | ||
| const white = "#FFFFFF"; | ||
|
|
||
| export const color = { |
There was a problem hiding this comment.
question: I realize this is a draft PR...but can you add some comments or docs on how this works when you get a chance? I'm a little confused after looking at color.ts vs. color-thunderblocks.ts. The object entries are SO different, it's a bit difficult to understand the overlap! Does that only matter when you get to the theme merging part?
There was a problem hiding this comment.
I'm planning to add all of that later, but as you mentioned, this PR is very drafty, so I'll make sure to mark it as ready for review when I cover all the required parts. I need to work on other PRs first (and land them) before coming back to this one.
added 5 commits
April 8, 2025 10:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds the new ThunderBlocks theme to support the new classroom experience.
Issue: https://khanacademy.atlassian.net/browse/WB-1896
Test plan:
TBD