[SR] Prepare strings for translation - Add context to interactive graph strings #2407
Conversation
…nslation - Add context to interactive graph strings
|
Size Change: +1.36 kB (+0.29%) Total Size: 466 kB
ℹ️ View Unchanged
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (6bb64d0) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR2407If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.js -t PR2407 |
nishasy
requested review from
benchristel,
SonicScrewdriver,
mark-fitzgerald,
catandthemachines,
anakaren-rojas and
a team
| srQuadraticGraph: { | ||
| context: | ||
| "Aria label for the container containing a Quadratic function in the interactive graph widget.", | ||
| message: "A parabola on a 4-quadrant coordinate plane.", |
There was a problem hiding this comment.
| message: "A parabola on a 4-quadrant coordinate plane.", | |
| message: "A parabola.", |
Why mention the number of quadrants shown in the graph? I don't think this is actually correct; e.g. the graph might only show quadrant 1.
There was a problem hiding this comment.
I think we added "4-quadrant" this time because so many of the related strings refer to the quadrant number that something is in. Even if the vertex doesn't show up on the graph, it'll read the quadrant that it's in.
It's a fair point though. Since this would require copy updates from a designer, I'm going to punt it to the phase 2 string updates.
| @@ -505,7 +504,6 @@ export type PerseusStrings = { | |||
| point2X: string; | |||
| point2Y: string; | |||
| }) => string; | |||
| // The above strings are used for interactive graph SR descriptions. | |||
There was a problem hiding this comment.
I actually liked having this context, as the organization made it easier for our future selves to quickly find the chunk of strings! I'm not fussed either way, however as I know we have some great context on the strings themselves. :)
Co-authored-by: Ben Christel <[email protected]>
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/[email protected] ### Patch Changes - [#2407](#2407) [`016357a5b`](016357a) Thanks [@nishasy](https://github.com/nishasy)! - [SR] Prepare strings for translation - Add context to interactive graph strings ## @khanacademy/[email protected] ### Patch Changes - Updated dependencies \[[`016357a5b`](016357a)]: - @khanacademy/[email protected]
Summary:
We held off on translations until now, beacuse the Interactive Graph strings were
still in flux. Now that they're finalized, we can send them in for translations.
I added context to all the strings that need to be translated so that
the context is for each individual string.
Since these are going to count as new strings, they'll trigger the
action on the PR that will create a translation ticket for us that's
pre-populated with all new strings.
NOTE: This PR is probably easier to review with the "Hide whitespace" option.
Issue: https://khanacademy.atlassian.net/browse/LEMS-2660
Test plan: