[CX] Allow option to rotate axis labels on interactive graphs #2284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +670 B (+0.08%) Total Size: 876 kB
ℹ️ View Unchanged
|
SonicScrewdriver
force-pushed
the
rotated-axis-labels
branch
from
021cad5 to
c4afe08
Compare
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (9dfa73a) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR2284If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR2284 |
|
Note: This work was actually completed by @SonicScrewdriver. We paired on reviewing it together. |
SonicScrewdriver
approved these changes
Mar 12, 2025
Merged
SonicScrewdriver
added a commit
that referenced
this pull request
Mar 19, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/[email protected] ### Major Changes - [#2303](#2303) [`5e7a6084c`](5e7a608) Thanks [@benchristel](https://github.com/benchristel)! - Drop support for using KaTeX as a math renderer. You may encounter styling issues or TeX syntax errors if you try to implement `PerseusDependencies.TeX` using KaTeX. ### Minor Changes - [#2284](#2284) [`0d5ab0b2e`](0d5ab0b) Thanks [@nishasy](https://github.com/nishasy)! - Add new labelLocation value for Interactive Graphs - [#875](#875) [`9737eb497`](9737eb4) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Remove deprecated khan-exercise.css - [#2305](#2305) [`af6d89007`](af6d890) Thanks [@Myranae](https://github.com/Myranae)! - Add a story for Dropdown that uses answerless data ### Patch Changes - [#2307](#2307) [`dd7b13a78`](dd7b13a) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Revert SSS temporarily for Radio to ensure Multiselect + Random answer correctness is accurate - Updated dependencies \[[`0d5ab0b2e`](0d5ab0b), [`fea65eaf1`](fea65ea)]: - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Major Changes - [#2303](#2303) [`5e7a6084c`](5e7a608) Thanks [@benchristel](https://github.com/benchristel)! - Drop support for using KaTeX as a math renderer. You may encounter styling issues or TeX syntax errors if you try to implement `PerseusDependencies.TeX` using KaTeX. ### Minor Changes - [#2284](#2284) [`0d5ab0b2e`](0d5ab0b) Thanks [@nishasy](https://github.com/nishasy)! - Add new labelLocation value for Interactive Graphs ### Patch Changes - Updated dependencies \[[`0d5ab0b2e`](0d5ab0b), [`fea65eaf1`](fea65ea), [`9737eb497`](9737eb4), [`dd7b13a78`](dd7b13a), [`af6d89007`](af6d890), [`5e7a6084c`](5e7a608)]: - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Minor Changes - [#2284](#2284) [`0d5ab0b2e`](0d5ab0b) Thanks [@nishasy](https://github.com/nishasy)! - Add new labelLocation value for Interactive Graphs ### Patch Changes - [#2300](#2300) [`fea65eaf1`](fea65ea) Thanks [@benchristel](https://github.com/benchristel)! - Bugfix: allow the 'key' field of Radio widgets to be null when parsing Perseus JSON ## @khanacademy/[email protected] ### Patch Changes - Updated dependencies \[[`0d5ab0b2e`](0d5ab0b), [`fea65eaf1`](fea65ea)]: - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - Updated dependencies \[[`0d5ab0b2e`](0d5ab0b), [`fea65eaf1`](fea65ea)]: - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - Updated dependencies \[[`0d5ab0b2e`](0d5ab0b), [`fea65eaf1`](fea65ea)]: - @khanacademy/[email protected] - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - Updated dependencies \[[`0d5ab0b2e`](0d5ab0b), [`fea65eaf1`](fea65ea)]: - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - Updated dependencies \[[`0d5ab0b2e`](0d5ab0b), [`fea65eaf1`](fea65ea)]: - @khanacademy/[email protected] - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - Updated dependencies \[[`0d5ab0b2e`](0d5ab0b), [`fea65eaf1`](fea65ea)]: - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected]
SonicScrewdriver
pushed a commit
that referenced
this pull request
Mar 20, 2025
## Summary: This PR is part of the Interactive Graph Project. The purpose of this PR is to add a new option that will allow Content Creators to change the location of the axis labels between "onAxis" and "alongEdge". Note: While working on this ticket, a long-standing bug was found where the axis labels will continue to stretch further away from their desired locations on largely positive or negative graphs. This will require clamping the min/max values for our calculations. However, adding that logic was making this ticket seem quite complicated so I have opted to create a separate ticket for handling this. See https://khanacademy.atlassian.net/browse/LEMS-2912 for more details. ## Screenshots: ### onAxis (Default)  ### alongEdge  Issue: https://khanacademy.atlassian.net/browse/LEMS-2718 ## Test plan: - New tests - Tests Pass - Manual Testing Author: nishasy Reviewers: SonicScrewdriver Required Reviewers: Approved By: SonicScrewdriver Checks: ✅ 8 checks were successful Pull Request URL: #2284
SonicScrewdriver
added a commit
that referenced
this pull request
Mar 20, 2025
## Summary: This PR redeploys [the labelLocation work](#2284) with several fixes: 1. A fix was applied to the InteractiveGraphBuilder to ensure that `labelLocation` will default to `undefined` for manual testing purposes. 2. A fix was applied to th transform logic to account for `labelLocation` being undefined. 3. The transform logic was extracted out into a separate function for testing purposes. ## Test plan: - manual testing - new tests Author: SonicScrewdriver Reviewers: nishasy Required Reviewers: Approved By: nishasy Checks: ✅ 12 checks were successful, ⌛ 1 check is pending Pull Request URL: #2316
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR is part of the Interactive Graph Project.
The purpose of this PR is to add a new option that will allow Content Creators to change the location of the axis labels between "onAxis" and "alongEdge".
Note: While working on this ticket, a long-standing bug was found where the axis labels will continue to stretch further away from their desired locations on largely positive or negative graphs. This will require clamping the min/max values for our calculations. However, adding that logic was making this ticket seem quite complicated so I have opted to create a separate ticket for handling this. See https://khanacademy.atlassian.net/browse/LEMS-2912 for more details.
Screenshots:
onAxis (Default)
alongEdge
Issue: https://khanacademy.atlassian.net/browse/LEMS-2718
Test plan: