[SR] Allow using control + shift + arrow keys for NVDA #2257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eys for NVDA todo Issue: none Test plan: todo
nishasy
changed the title
…+ shift + arrow keys for NVDA
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (5071aac) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR2257If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR2257 |
|
Size Change: +15 B (0%) Total Size: 735 kB
ℹ️ View Unchanged
|
nishasy
changed the title
|
Question, does this solution still work for screen reader users who have different modifier keys set or Voiceover? 🤔 |
nishasy
requested review from
mark-fitzgerald,
SonicScrewdriver and
catandthemachines
SonicScrewdriver
approved these changes
Mar 19, 2025
Merged
nishasy
added a commit
that referenced
this pull request
Mar 19, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/[email protected] ### Patch Changes - [#2309](#2309) [`7be7a42d6`](7be7a42) Thanks [@nishasy](https://github.com/nishasy)! - [SR] Update graph elements so their aria-describedby is read in non-Chrome browsers - [#2257](#2257) [`1e67022c9`](1e67022) Thanks [@nishasy](https://github.com/nishasy)! - [SR] Allow using control + shift + arrow keys for NVDA ## @khanacademy/[email protected] ### Patch Changes - Updated dependencies \[[`7be7a42d6`](7be7a42), [`1e67022c9`](1e67022)]: - @khanacademy/[email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
NVDA takes control of inputs in its default mode, so users can't use just the arrow keys to move the interactive elements on the graph. We want to allow using modifier key + control + shift + arrow keys to move interactive elements on the graph.
Note: This already works with the modifier key + shift + arrow keys (no control), but holding down shift makes it so that the amount the element moves is 4x more than without shift.
Note 2: When using NVDA, you can get the same keyboard experience as not using a screen reader (i.e. move the points with arrow keys only) if you go into focus mode (NVDA key + space bar).
Implemented:
Issue: https://khanacademy.atlassian.net/browse/LEMS-2874
Test plan:
yarn jest packages/perseus/src/widgets/interactive-graphs/interactive-graph.test.tsxStorybook
http://localhost:6006/?path=/docs/perseuseditor-widgets-interactive-graph--docs