-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Enhance CippExchangeSettingsForm and user exchange page with mailbox permissions management #4187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Jr7468
commented
Jun 1, 2025
- Added cardLabelBoxActions to CippBannerListCard for displaying action buttons.
- Introduced mailbox permissions management in CippExchangeSettingsForm, including form controls for adding Full Access, Send-as, and Send On Behalf permissions.
- Implemented a dialog for adding mailbox permissions with validation and submission handling.
- Refactored user exchange page to integrate new permissions functionality and manage state for permissions submission.
…permissions management - Added cardLabelBoxActions to CippBannerListCard for displaying action buttons. - Introduced mailbox permissions management in CippExchangeSettingsForm, including form controls for adding Full Access, Send-as, and Send On Behalf permissions. - Implemented a dialog for adding mailbox permissions with validation and submission handling. - Refactored user exchange page to integrate new permissions functionality and manage state for permissions submission.
JohnDuprey
reviewed
Jun 1, 2025
RemoveSendAs: { | ||
value: "User" | ||
} | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should use a customFunction to post the mailbox permission remove otherwise you're removing more than that row
JohnDuprey
reviewed
Jun 1, 2025
|
||
setIsSubmittingPermissions(true); | ||
setSubmitPermissionsResult(null); | ||
fetch('/api/ExecEditMailboxPermissions', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be using ApiPostCall
minor tweaks
- Add mailbox forwarding configuration with internal/external options - Implement calendar permissions management interface - Add Out of Office (OOO) settings configuration - Add recipient limits management functionality - Improve form handling and validation for Exchange settings
… be added at once, in a cleaner format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.