Skip to content

Graph Filter support #1506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/components/tables/CippDatatable.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,20 @@ import { CippTablePropTypes } from 'src/components/tables/CippTable'

export default function CippDatatable({ path, params, ...rest }) {
const [refreshGuid, setRefreshGuid] = React.useState('')
const [graphFilter, setGraphFilter] = React.useState('')
const {
data = [],
isFetching,
error,
} = useListDatatableQuery({ path, params: { refreshGuid, ...params } })
} = useListDatatableQuery({ path, params: { refreshGuid, graphFilter, ...params } })
return (
<CippTable
{...rest}
data={data}
isFetching={isFetching}
error={error}
refreshFunction={setRefreshGuid}
graphFilterFunction={setGraphFilter}
/>
)
}
Expand Down
57 changes: 49 additions & 8 deletions src/components/tables/CippTable.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,14 @@ import { ModalService } from '../utilities'
import { useLazyGenericGetRequestQuery, useLazyGenericPostRequestQuery } from 'src/store/api/app'
import { ConfirmModal } from '../utilities/SharedModal'

const FilterComponent = ({ filterText, onFilter, onClear, filterlist, onFilterPreset }) => (
const FilterComponent = ({
filterText,
onFilter,
onClear,
filterlist,
onFilterPreset,
onFilterGraph,
}) => (
<>
<CInputGroup>
<CDropdown variant="input-group">
Expand All @@ -38,14 +45,29 @@ const FilterComponent = ({ filterText, onFilter, onClear, filterlist, onFilterPr
<FontAwesomeIcon icon={faSearch} color="#3e5c66" />
</CDropdownToggle>
<CDropdownMenu>
<CDropdownItem onClick={() => onFilterPreset('')}>Clear Filter</CDropdownItem>
<CDropdownItem
onClick={() => {
onFilterPreset('')
onFilterGraph('')
}}
>
Clear Filter
</CDropdownItem>
{filterlist &&
filterlist.map((item, idx) => {
return (
<CDropdownItem key={idx} onClick={() => onFilterPreset(item.filter)}>
{item.filterName}
</CDropdownItem>
)
if (item.hasOwnProperty('graphFilter') && item.graphFilter == true) {
return (
<CDropdownItem key={idx} onClick={() => onFilterGraph(item.filter)}>
{item.filterName}
</CDropdownItem>
)
} else {
return (
<CDropdownItem key={idx} onClick={() => onFilterPreset(item.filter)}>
{item.filterName}
</CDropdownItem>
)
}
})}
</CDropdownMenu>
</CDropdown>
Expand All @@ -69,6 +91,7 @@ FilterComponent.propTypes = {
onClear: PropTypes.func,
filterlist: PropTypes.arrayOf(PropTypes.object),
onFilterPreset: PropTypes.func,
onFilterGraph: PropTypes.func,
}

const customSort = (rows, selector, direction) => {
Expand Down Expand Up @@ -99,6 +122,7 @@ export default function CippTable({
error,
reportName,
refreshFunction = null,
graphFilterFunction = null,
columns = [],
dynamicColumns = true,
filterlist,
Expand Down Expand Up @@ -142,6 +166,16 @@ export default function CippTable({
const filteredItems = data.filter(
(item) => JSON.stringify(item).toLowerCase().indexOf(filterText.toLowerCase()) !== -1,
)
const applyFilter = (e) => {
setFilterText(e.target.value)
}

const setGraphFilter = (e) => {
if (graphFilterFunction) {
graphFilterFunction(e)
}
}

useEffect(() => {
if (columns !== updatedColumns) {
setUpdatedColumns(columns)
Expand Down Expand Up @@ -400,7 +434,14 @@ export default function CippTable({
<div className="w-100 d-flex justify-content-start">
<FilterComponent
onFilter={(e) => setFilterText(e.target.value)}
onFilterPreset={(e) => setFilterText(e)}
onFilterPreset={(e) => {
setFilterText(e)
setGraphFilter('')
}}
onFilterGraph={(e) => {
setFilterText('')
setGraphFilter(e)
}}
onClear={handleClear}
filterText={filterText}
filterlist={filterlist}
Expand Down
5 changes: 5 additions & 0 deletions src/views/identity/administration/Users.js
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,11 @@ const Users = (row) => {
{ filterName: 'Guest users', filter: '"usertype":"guest"' },
{ filterName: 'Users with a license', filter: '"assignedLicenses":[{' },
{ filterName: 'Users without a license', filter: '"assignedLicenses":[]' },
{
filterName: 'Users with a license (Graph)',
filter: 'assignedLicenses/$count ne 0',
graphFilter: true,
},
],
columns,
path: '/api/ListUsers',
Expand Down