[Bug]: Vacation Mode Inconsistent with Additions and Removals

[theknoxtech]

Required confirmations before submitting

• I can reproduce this issue on the latest released versions of both CIPP and CIPP-API.
• I have searched existing issues (both open and closed) to avoid duplicates.
• I am not requesting general support; this is an actual bug report.

Issue Description

We have opened a support ticket for this issue, and we wanted to make sure that this was officially reported here as a bug report. When scheduling multiple users in vacation mode, if the same time is selected for each account when adding OR removing the tasks will fail to execute for one or more of the accounts.

We can replicate this on demand. However, the logs show that it executed the task of adding or removing for each account. It isn't until you login to Entra and look at the policy that you find it actually didn't.

We have staggered the accounts in 15 minutes intervals, and this also fails. The only solution that has shown to work is 30 minute intervals between the additions and the removals. However, in our testing if any of the executions happen at the same time whether add and remove or a combination of them there is a high chance of failure.

We feel like this can create an unnecessary attack vector if a removal is not actually performed. For now we will use the 30 minute intervals, but this also takes away from the efficiency of the feature. It has been observed that this issue may be only with multiple accounts at the same time in the same tenant. One test using two tenants but adding the accounts at the same time seemed to work.

Environment Type

Sponsored (paying) user

Front End Version

8.1.1

Back End Version

8.1.1

Relevant Logs / Stack Trace

[github-actions]

Thank you for reporting a potential bug. If you would like to work on this bug, please comment:

I would like to work on this please!

Thank you for helping us maintain the project!

[rvdwegen]

Hi @theknoxtech,

Could you confirm if this is still happening after the release from a few weeks ago? That included a fix to stagger executions.