Move some functions, modernize and support POST and GET #1313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing and improve message handling dont throw cause it break stuff if it fails fix typo
statuscode and remove useless stuff Refactor Invoke-RemoveAPDevice to unify tenant filter retrieval and improve logging messages
…SharedMailboxAccountEnabled
…-ListGroupSenderAuthentication
…ed logging and error handling
…mproved parameter handling and logging
…onsistency and clarity
…ameter management
…parameter handling, logging, and error management
…management, and logging
…ed parameter handling, error management, and logging Casing and add displayName param
…and error management
… handling, logging, and response management
…nd logging consistency
…ency, and error messaging
kris6673
changed the title
JohnDuprey
reviewed
Feb 24, 2025
Modules/CIPPCore/Public/Entrypoints/HTTP Functions/CIPP/Settings/Invoke-ExecCPVPermissions.ps1
Show resolved
Hide resolved
There was a problem hiding this comment.
we could probably use exo bulk requests
There was a problem hiding this comment.
I converted it from that. This cmdlet is dumb and annoying and does not tell what type it returns, so the remove function had to figure it out in the backend when trying to remove. That sometimes worked, but a domain like "domain.dk" could both be of the "Sender" or "URL" type, causing the deletion to fail.
Using parralel and adding the property be hand seemed like the most elegant and BRRRRRRRR solution when the bulk request didnt really do what was needed.
Modules/CIPPCore/Public/Entrypoints/HTTP Functions/Tenant/GDAP/Invoke-ListGDAPQueue.ps1
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor various mailbox management functions for improved parameter handling, error logging, and message processing. Implement new mailbox conversion functionality and support for POST requests. Ensure consistent casing for parameters across functions.
Frontend PR: KelvinTegelaar/CIPP#3660