0006867: Made it possible to track engine uninstallation progress #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavel-jm
reviewed
May 9, 2025
symmetric-core/src/main/java/org/jumpmind/symmetric/AbstractSymmetricEngine.java
Show resolved
Hide resolved
pavel-jm
approved these changes
May 9, 2025
awebbdev1
reviewed
May 9, 2025
symmetric-core/src/main/java/org/jumpmind/symmetric/ISymmetricEngine.java
Outdated
Show resolved
Hide resolved
erilong
requested changes
May 9, 2025
symmetric-core/src/main/java/org/jumpmind/symmetric/ISymmetricEngine.java
Outdated
Show resolved
Hide resolved
…() instead of a ProcessInfo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roughly 15-20% of the time spent uninstalling an engine is spent dropping triggers. I weighted the progress accordingly, but I can't update the progress as each trigger is dropped without adding an additional database query. I decided that it would be best to avoid running an additional query, so the progress for dropping triggers only updates when all triggers have been dropped.