Set max distance to one when it's zero #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #65 +/- ##
==========================================
- Coverage 93.20% 93.17% -0.04%
==========================================
Files 2 2
Lines 206 205 -1
==========================================
- Hits 192 191 -1
Misses 14 14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
andreasnoack
force-pushed
the
an/issue28
branch
from
e194933 to
81e1471
Compare
This avoids a NaN in the tricubic weight calculation and instead all the observations end up unweighted. This makes all the examples from issue 28 work.
andreasnoack
force-pushed
the
an/issue28
branch
from
81e1471 to
453d45b
Compare
|
@devmotion this small followup is also ready now |
devmotion
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids a NaN in the tricubic weight calculation and instead
all the observations end up unweighted. This makes all the examples
from issue 28 work.
This PR is based on top of #64 so that one should ideally be merged first.
Closes #28