Fix some NaN problems and a few other fixes. #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
reviewed
Dec 14, 2020
|
Also looks like CI here is dead. Guess we'll have to migrate to GitHub Actions if we want to actually test things. |
|
Thanks for the review. I'll handle the migration to GA. |
factorization when solving the local system to avoid error when the system is singular. Also fix a one-off error in the median calculation in the KDTree implementation.
andreasnoack
force-pushed
the
an/fixes
branch
from
c507b44 to
df1bf95
Compare
|
I've enabled GA and updated the PR with the recommendations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle prediction at tree split points separately. Always use qr
factorization when solving the local system to avoid error when
the system is singular. Also fix a one-off error in the median
calculation in the KDTree implementation.
This fixes some of the issues mentioned in #28 though not all
of them. The solution is to error out informatively in some cases
when the local system becomes too small. I think the main remaining
item is to handle ties differently. I expect that we'd have to construct
the tree only based on unique elements but that is for a future PR.
For now, I've added the test cases with ties from #28 but marked
some of them with
@test_broken.