Remove broken shields, fix broadcasting, use extrema. #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bunch of trivial fixes: - pkg.julia.org shield links are broken, remove - fixes part of #31 - use extrema for min/max, slightly more idiomatic
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
==========================================
+ Coverage 88.74% 92.46% +3.72%
==========================================
Files 2 2
Lines 151 146 -5
==========================================
+ Hits 134 135 +1
+ Misses 17 11 -6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of trivial fixes:
pkg.julia.org shield links are broken, remove
fixes part of example on readme not working #31
use extrema for min/max, slightly more idiomatic