Skip to content

A few updates #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 29, 2019
Merged

A few updates #30

merged 7 commits into from
Jan 29, 2019

Conversation

ararslan
Copy link
Member

@ararslan ararslan commented Jan 29, 2019

I've separated things out into distinct commits:

  • Normalize indentation. Currently there's a mix of tabs and spaces.
  • Add a Project.toml and a .gitignore.
  • Relax type constraints in the loess definition, which fixes Integer input not accepted #27.
  • Add Julia 1.1 testing and Codecov submission to Travis.
  • Remove macOS from Travis. The queues are long and there's no platform specific code here.
  • Remove unnecessary __precompile__, since it's the default.
  • Use DimensionMismatch instead of error when checking dimension consistency.

The queues are long since resources are more limited, and this package
has no platform-specific code or binary dependencies which make testing
on multiple systems worthwhile.
@codecov-io
Copy link

codecov-io commented Jan 29, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@df352ae). Click here to learn what that means.
The diff coverage is 85.52%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #30   +/-   ##
=========================================
  Coverage          ?   88.74%           
=========================================
  Files             ?        2           
  Lines             ?      151           
  Branches          ?        0           
=========================================
  Hits              ?      134           
  Misses            ?       17           
  Partials          ?        0
Impacted Files Coverage Δ
src/Loess.jl 84.61% <82.92%> (ø)
src/kd.jl 93.15% <88.57%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df352ae...6c23e1a. Read the comment docs.

@ararslan ararslan merged commit b98ae19 into master Jan 29, 2019
@ararslan ararslan deleted the aa/stuff branch January 29, 2019 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integer input not accepted
3 participants